Hide support for PostgreSQL arrays behind a config switch#687
Merged
electrum merged 1 commit intotrinodb:masterfrom May 3, 2019
Merged
Hide support for PostgreSQL arrays behind a config switch#687electrum merged 1 commit intotrinodb:masterfrom
electrum merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
As we want to replace existing mapping with something more suitable, the first step is to provide a config toggle that will help during transition period.
electrum
approved these changes
May 2, 2019
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
This seems fine for the next release. What happens today if the dimensionality of the runtime value doesn't match the declared dimensionality?
Member
|
We discussed this on Slack and decided to ship this for now, to avoid locking in the current behavior (which might not be the correct default behavior). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we want to replace existing mapping with something more suitable (#682), the
first step is to provide a config toggle that will help during
transition period.