Test all file formats in TestSparkCompatibility#6699
Closed
lxynov wants to merge 3 commits intotrinodb:masterfrom
Closed
Test all file formats in TestSparkCompatibility#6699lxynov wants to merge 3 commits intotrinodb:masterfrom
lxynov wants to merge 3 commits intotrinodb:masterfrom
Conversation
lxynov
force-pushed
the
TestSparkCompatibility
branch
2 times, most recently
from
ee8bf92 to
465f8a8
Compare
lxynov
changed the title
Member
Author
phd3
reviewed
Jan 26, 2021
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
Thanks, just some minor comments.
...ces/docker/presto-product-tests/conf/environment/singlenode-spark-iceberg/iceberg.properties
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/iceberg/TestSparkCompatibility.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/iceberg/TestSparkCompatibility.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/iceberg/TestSparkCompatibility.java
Outdated
Show resolved
Hide resolved
lxynov
force-pushed
the
TestSparkCompatibility
branch
from
465f8a8 to
63ac92b
Compare
lxynov
force-pushed
the
TestSparkCompatibility
branch
from
63ac92b to
4dc1f6a
Compare
Member
Author
phd3
reviewed
Feb 6, 2021
| String baseTableName = "test_spark_reads_presto_partitioned_table_" + format; | ||
| String prestoTableName = prestoTableName(baseTableName); | ||
| onPresto().executeQuery(format("CREATE TABLE %s (_string VARCHAR, _bigint BIGINT) WITH (partitioning = ARRAY['_string'])", prestoTableName)); | ||
| onPresto().executeQuery(format("CREATE TABLE %s (_string VARCHAR, _bigint BIGINT) WITH (partitioning = ARRAY['_string'], format = '" + format + "')", prestoTableName)); |
Member
There was a problem hiding this comment.
Suggested change
| onPresto().executeQuery(format("CREATE TABLE %s (_string VARCHAR, _bigint BIGINT) WITH (partitioning = ARRAY['_string'], format = '" + format + "')", prestoTableName)); | |
| onPresto().executeQuery(format("CREATE TABLE %s (_string VARCHAR, _bigint BIGINT) WITH (partitioning = ARRAY['_string'], format = '%s')", prestoTableName, format)); |
sorry if it was confusing, meant a change like the above in #6699 (comment)
Member
|
Superseded by #8751 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trino started failing to read Spark-created ORC Iceberg tables for some reason. See CI result for reference
Update: Fixed after
iceberg.use-file-size-from-metadata=falseis set. Thanks to @phd3