Separate query rendering from statement creation in QueryBuilder#6688
Merged
findepi merged 4 commits intotrinodb:masterfrom Jan 22, 2021
Merged
Separate query rendering from statement creation in QueryBuilder#6688findepi merged 4 commits intotrinodb:masterfrom
findepi merged 4 commits intotrinodb:masterfrom
Conversation
`QueryBuilder.buildSql` had two responsibilities: - prepare query text for execution - initiate `PreparedStatement` object They are now refactored into separate methods. For this, `BoundValue` is replaced with `QueryParameter`. The new class is serializable.
This keeps the query text shorter (perhaps faster to parse on the remote side) and more readable for debugging purposes.
losipiuk
approved these changes
Jan 22, 2021
kokosing
reviewed
Jan 22, 2021
Member
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
overall looks good, but I only skimmed (please do not wait on me if somebody else give you a decent review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #6620
extracted from #6667
to be used for #6287