Closed
Conversation
hashhar
force-pushed
the
hashhar/cleanup-pushdowns
branch
from
b89ef89 to
236d00b
Compare
findepi
reviewed
Jan 22, 2021
| { | ||
| return basicAggregation() | ||
| .with(functionName().equalTo("stddev_pop")) | ||
| .with(functionName().matching(name -> name.equalsIgnoreCase("stddev_pop"))) |
Member
There was a problem hiding this comment.
i see .with(functionName().equalto 10 times in the codebase.
We should rather change the functionName().equalto impl, that "workaround" it in every place
Member
Author
There was a problem hiding this comment.
I'm creating a new PR for just the comments added to SqlServerClient about the missing pushdowns.
Will update this PR with suggested changes before the upcoming release.
findepi
reviewed
Jan 22, 2021
| { | ||
| Variable input = captures.get(INPUT); | ||
| JdbcColumnHandle columnHandle = (JdbcColumnHandle) context.getAssignment(input.getName()); | ||
| verifyNotNull(columnHandle, "Unbound variable: %s", input); |
Member
There was a problem hiding this comment.
redundant, already checked by ontext.getAssignment
Member
Author
|
This seems to have been covered in #6736. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up SqlServer pushdown implementations to be more consistent.
Also documents why
covar_sampandcovar_popare not implemented.