Skip to content

HAVING pushdown and more advanced aggregation pushdown in JDBC connectors #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 5 commits into from
Jan 25, 2021
Merged

HAVING pushdown and more advanced aggregation pushdown in JDBC connectors #6667

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78c96cf
Remove JdbcColumnHandle.isSynthetic
findepi Jan 20, 2021
524c3dc
Remove Presto reference
findepi Jan 21, 2021
1cc663c
Represent query-based relation in JdbcTableHandle
findepi Jan 19, 2021
781d40f
Accept PreparedQuery in QueryBuilder
findepi Jan 19, 2021
2215497
Use Query-based table handles in JDBC connectors
findepi Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcColumnHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package io.trino.plugin.jdbc;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Joiner;
import io.trino.spi.connector.ColumnHandle;
Expand Down Expand Up @@ -109,12 +108,6 @@ public Optional<String> getComment()
return comment;
}

@JsonIgnore
public boolean isSynthetic()
{
return expression.isPresent();
}

public ColumnMetadata getColumnMetadata()
{
return ColumnMetadata.builder()
Expand Down
6 changes: 1 addition & 5 deletions plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
public class JdbcMetadata
implements ConnectorMetadata
{
private static final String SYNTHETIC_COLUMN_NAME_PREFIX = "_presto_generated_";
private static final String SYNTHETIC_COLUMN_NAME_PREFIX = "_pfgnrtd_";

@losipiuk losipiuk Jan 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tf...?

@findepi findepi Jan 21, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo... ?

@kokosing kokosing Jan 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_trino_generated_?

@losipiuk losipiuk Jan 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh makes sense :P

@ssheikin ssheikin Jun 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣


private final JdbcClient jdbcClient;
private final boolean allowDropTable;
Expand Down Expand Up @@ -436,7 +436,6 @@ public ConnectorInsertTableHandle beginInsert(ConnectorSession session, Connecto
verify(!((JdbcTableHandle) tableHandle).isSynthetic(), "Not a table reference: %s", tableHandle);
List<JdbcColumnHandle> columnHandles = columns.stream()
.map(JdbcColumnHandle.class::cast)
.peek(columnHandle -> verify(!columnHandle.isSynthetic(), "Not a column reference: %s", columnHandle))
.collect(toImmutableList());
JdbcOutputTableHandle handle = jdbcClient.beginInsertTable(session, (JdbcTableHandle) tableHandle, columnHandles);
setRollback(() -> jdbcClient.rollbackCreateTable(session, handle));
Expand All @@ -463,7 +462,6 @@ public void setColumnComment(ConnectorSession session, ConnectorTableHandle tabl
JdbcTableHandle tableHandle = (JdbcTableHandle) table;
JdbcColumnHandle columnHandle = (JdbcColumnHandle) column;
verify(!tableHandle.isSynthetic(), "Not a table reference: %s", tableHandle);
verify(!columnHandle.isSynthetic(), "Not a column reference: %s", columnHandle);
jdbcClient.setColumnComment(session, tableHandle, columnHandle, comment);
}

Expand All @@ -481,7 +479,6 @@ public void dropColumn(ConnectorSession session, ConnectorTableHandle table, Col
JdbcTableHandle tableHandle = (JdbcTableHandle) table;
JdbcColumnHandle columnHandle = (JdbcColumnHandle) column;
verify(!tableHandle.isSynthetic(), "Not a table reference: %s", tableHandle);
verify(!columnHandle.isSynthetic(), "Not a column reference: %s", columnHandle);
jdbcClient.dropColumn(session, tableHandle, columnHandle);
}

Expand All @@ -491,7 +488,6 @@ public void renameColumn(ConnectorSession session, ConnectorTableHandle table, C
JdbcTableHandle tableHandle = (JdbcTableHandle) table;
JdbcColumnHandle columnHandle = (JdbcColumnHandle) column;
verify(!tableHandle.isSynthetic(), "Not a table reference: %s", tableHandle);
verify(!columnHandle.isSynthetic(), "Not a column reference: %s", columnHandle);
jdbcClient.renameColumn(session, tableHandle, columnHandle, target);
}

Expand Down