Skip to content

Enable oracle aggregation pushdown#6358

Closed
jles01 wants to merge 13 commits intotrinodb:masterfrom
jles01:master
Closed

Enable oracle aggregation pushdown#6358
jles01 wants to merge 13 commits intotrinodb:masterfrom
jles01:master

Conversation

@jles01
Copy link

@jles01 jles01 commented Dec 16, 2020

Changes related to make aggregation calculated by oracle.

Fixes #5208

jles0518 and others added 4 commits December 16, 2020 12:03
Aggregation pushdown for oracle
Aggregation push down oracle test
Aggregation push down oracle -docs
@cla-bot
Copy link

cla-bot bot commented Dec 16, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

add function implementAggregation
@cla-bot
Copy link

cla-bot bot commented Dec 16, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

Fix whitespace issue
@cla-bot
Copy link

cla-bot bot commented Dec 16, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

@tooptoop4
Copy link
Contributor

@jles01 no ImplementAvgBigint.java change? like https://github.com/prestosql/presto/pull/5563/files has

@cla-bot
Copy link

cla-bot bot commented Dec 17, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

@jles01
Copy link
Author

jles01 commented Dec 17, 2020

@jles01 no ImplementAvgBigint.java change? like https://github.com/prestosql/presto/pull/5563/files has

I added the corresponding change, in addition I added fetch size as a parameter. For huge tables(100billions+) increasing it from default 1000 to 100000 is huge performance improvement.

@ebyhr
Copy link
Member

ebyhr commented Dec 17, 2020

I added fetch size as a parameter. For huge tables(100billions+) increasing it from default 1000 to 100000 is huge performance improvement.

@jles01 fetchSize is ongoing in #3775. I would recommend avoiding to mixup two enhancement in a PR.

@jles01
Copy link
Author

jles01 commented Dec 17, 2020

ohhh did not saw that, will revert

@cla-bot
Copy link

cla-bot bot commented Dec 17, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

@cla-bot
Copy link

cla-bot bot commented Dec 17, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

@cla-bot
Copy link

cla-bot bot commented Dec 21, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

@jles01 jles01 marked this pull request as draft December 30, 2020 14:16
@jles01 jles01 closed this Dec 30, 2020
@jles01 jles01 reopened this Dec 30, 2020
@jles01 jles01 marked this pull request as ready for review December 30, 2020 14:17
@jles01 jles01 requested review from ebyhr and findepi January 18, 2021 12:06
@ebyhr
Copy link
Member

ebyhr commented Jan 18, 2021

@jles01 Could you rebase on upstream to resolve conflicts? We changed directory structure and Java package. This wiki describes migration steps. https://github.com/trinodb/trino/wiki/Developer-Migration

@martint
Copy link
Member

martint commented May 12, 2021

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented May 12, 2021

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label May 12, 2021
@jles01 jles01 closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Aggregation pushdown in Oracle connector

5 participants