Remove unnecessary socketchannelcocketfactory#6002
Remove unnecessary socketchannelcocketfactory#6002PennyAndWang wants to merge 1 commit intotrinodb:masterfrom
Conversation
|
@PennyAndWang please rebase the PR on current master, so that there is no "Merge .." commit in https://github.com/prestosql/presto/pull/6002/commits |
54886ad to
44d87b1
Compare
|
@findepi Done !
|
|
@electrum could you please help me review ? thx~~~ |
|
@findepi Hi, this PR has been opened for 4 months, I don’t know whether you could review this PR for me or not . THX |
|
@PennyAndWang i asked @electrum for the review (#6002 (comment)), because he knows this area of code much better. I don't know much about why have But... i am sorry, but could you please rebase the PR? |
@findepi ,Hi, sorry to bother you again. I have rebased this PR, I need to continue rebase ? or I understand something wrong ? or What am I missing? |
|
Merged as eeed38b. |
@electrum , according to what you said in this PR :#5915 , I remove the unnecessary SocketChannelSocketFactory ,please review ,thx!