Closed
Conversation
wendigo
force-pushed
the
serafin/simplify-string-literal
branch
from
9ffef71 to
2fce3ab
Compare
wendigo
force-pushed
the
serafin/simplify-string-literal
branch
from
2fce3ab to
b7ed48c
Compare
findepi
approved these changes
Oct 22, 2020
Member
|
The change is ok, but we should consider removing the Slice altogether and leaving a String instead. The reason we had the Slice representation was that years ago query execution was based on an expression interpreter, which ended up performing the String->Slice conversion every time. This hasn't been the case in a long time, so keeping the Slice provides very little value. |
Member
|
If we go with String, we should also update places like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.