Support coercing varchar types in hive#5530
Merged
phd3 merged 2 commits intotrinodb:masterfrom Oct 26, 2020
Merged
Conversation
phd3
commented
Oct 12, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@findepi Does the test run |
phd3
force-pushed
the
coerce-varchar
branch
2 times, most recently
from
a15ce77 to
997c7c3
Compare
findepi
reviewed
Oct 16, 2020
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
thanks for working on this.
some editorial comments
presto-spi/src/main/java/io/prestosql/spi/type/VarcharType.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/coercions/VarcharCoercer.java
Outdated
Show resolved
Hide resolved
presto-product-tests/src/main/java/io/prestosql/tests/hive/TestHiveCoercion.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Oct 22, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@findepi thanks for your review, addressed comments. Would you like to take another look? |
findepi
approved these changes
Oct 26, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5484.