Make type name to be Optional in JdbcTypeHandle#523
Merged
kokosing merged 1 commit intotrinodb:masterfrom Apr 24, 2019
Merged
Conversation
kokosing
changed the title
findepi
reviewed
Mar 22, 2019
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
the code doesn't compile
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project presto-postgresql: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/prestosql/presto/presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java:[141,16] incompatible types: java.util.Optional<java.lang.String> cannot be converted to int
[ERROR] /home/travis/build/prestosql/presto/presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java:[148,84] incompatible types: java.util.Optional<java.lang.String> cannot be converted to java.lang.String
presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcTypeHandle.java
Outdated
Show resolved
Hide resolved
kokosing
force-pushed
the
origin/master/112_optional_type_name
branch
from
0fb71de to
2e17a55
Compare
kokosing
changed the title
Member
Author
|
@findepi This is ready for a review. |
findepi
reviewed
Mar 27, 2019
Member
There was a problem hiding this comment.
This should go to super.toPrestoType.
However, since we know postgresql types are properly named we can simply
String jdbcTypeName = typeHandle.getJdbcTypeName().orElseThrow
then you don't need if (!typeHandle.getJdbcTypeName().isPresent()) at all
Member
Author
There was a problem hiding this comment.
super.toPrestoType does not use getJdbcTypeName
kokosing
force-pushed
the
origin/master/112_optional_type_name
branch
from
2e17a55 to
af1fb81
Compare
kokosing
commented
Apr 9, 2019
Member
Author
There was a problem hiding this comment.
super.toPrestoType does not use getJdbcTypeName
findepi
approved these changes
Apr 9, 2019
presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
kokosing
force-pushed
the
origin/master/112_optional_type_name
branch
from
8ef6a8f to
e26f960
Compare
findepi
approved these changes
Apr 23, 2019
presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
presto-postgresql/src/main/java/io/prestosql/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
In some RDMBS there are types that do not have names.
kokosing
force-pushed
the
origin/master/112_optional_type_name
branch
from
d5e3b10 to
ce00ad0
Compare
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Aug 15, 2023
Cherry-pick of trinodb/trino#523 Co-authored-by: Grzegorz Kokosiński <grzegorz@starburstdata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make type name to be Optional in JdbcTypeHandle
In some RDMBS there are types that do not have names.