Skip to content

Adding ulimits guidance to deployment doc#5066

Merged
electrum merged 1 commit intotrinodb:masterfrom
m57lyra:open-file-descr-ulimit
Sep 24, 2020
Merged

Adding ulimits guidance to deployment doc#5066
electrum merged 1 commit intotrinodb:masterfrom
m57lyra:open-file-descr-ulimit

Conversation

@m57lyra
Copy link
Copy Markdown
Contributor

@m57lyra m57lyra commented Sep 3, 2020

  • balanced comments regarding modern linux systems and field observations
  • explicit that the ulimit is for the user that the presto process runs as

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2020
@m57lyra m57lyra added the docs label Sep 3, 2020
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
@m57lyra
Copy link
Copy Markdown
Contributor Author

m57lyra commented Sep 3, 2020

Changes so far...

Screen Shot 2020-09-03 at 3 03 24 PM

@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from 354488a to e3eeb86 Compare September 4, 2020 02:47
@m57lyra
Copy link
Copy Markdown
Contributor Author

m57lyra commented Sep 4, 2020

Hi folks! I went ahead and pushed the proposed changes, but did not remove the current limit checks from the code. Happy to make further changes as needed.

@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from e3eeb86 to 1966a8c Compare September 10, 2020 16:38
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from 1966a8c to cddb5c4 Compare September 10, 2020 20:39
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Sep 14, 2020

@electrum can you detail any other changes that are needed from a technical point of view. @m57lyra and myself are not sure what @kbajda and yourself agree on and what should be in the document now.

Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
Comment thread presto-docs/src/main/sphinx/installation/deployment.rst Outdated
@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from cddb5c4 to c94663e Compare September 18, 2020 04:46
@electrum electrum merged commit c2217b7 into trinodb:master Sep 24, 2020
@m57lyra m57lyra deleted the open-file-descr-ulimit branch September 29, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants