Merged
Conversation
kokosing
reviewed
Sep 1, 2020
...in-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedSystemAccessControl.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
cleanup-file-access-control
branch
from
ee6e12c to
2c49db5
Compare
kokosing
reviewed
Sep 2, 2020
...o-plugin-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
...in-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedSystemAccessControl.java
Outdated
Show resolved
Hide resolved
...-toolkit/src/main/java/io/prestosql/plugin/base/security/CatalogSchemaAccessControlRule.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
cleanup-file-access-control
branch
from
2c49db5 to
9347c2e
Compare
kokosing
previously approved these changes
Sep 2, 2020
dain
force-pushed
the
cleanup-file-access-control
branch
3 times, most recently
from
6bbb705 to
5e2da1a
Compare
dain
force-pushed
the
cleanup-file-access-control
branch
2 times, most recently
from
ab29061 to
12762aa
Compare
dain
force-pushed
the
cleanup-file-access-control
branch
from
12762aa to
92cc3e5
Compare
mosabua
reviewed
Sep 17, 2020
presto-docs/src/main/sphinx/admin/session-property-managers.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 17, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 17, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 17, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 17, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 18, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 18, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Sep 18, 2020
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
mosabua
requested changes
Sep 18, 2020
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
A bunch of minor suggestions for docs submitted. I have not looked at the code...
dain
force-pushed
the
cleanup-file-access-control
branch
from
92cc3e5 to
db77636
Compare
kokosing
reviewed
Sep 24, 2020
Member
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
LGTM for first 3 commits. Up to Change catalog check to match other checks. If you could merge them, then it will be easier to continue with that. It is quite hard for me to digest it all at once.
presto-plugin-toolkit/src/test/resources/file-based-system-no-access.json
Outdated
Show resolved
Hide resolved
...in-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedSystemAccessControl.java
Outdated
Show resolved
Hide resolved
...o-plugin-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/security/file-system-access-control.rst
Outdated
Show resolved
Hide resolved
...ugin-toolkit/src/test/java/io/prestosql/plugin/base/security/TestFileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
...oolkit/src/test/java/io/prestosql/plugin/base/security/TestFileBasedSystemAccessControl.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@kokosing I prefer to wait until you are done, and then I will merge... the first couple are simple cleanups, and I don't really want to split the PR. |
dain
dismissed
kokosing’s stale review
Code has been significantly updated since review
kokosing
approved these changes
Sep 30, 2020
presto-plugin-toolkit/src/main/java/io/prestosql/plugin/base/security/ImpersonationRule.java
Outdated
Show resolved
Hide resolved
...o-plugin-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
...in-toolkit/src/main/java/io/prestosql/plugin/base/security/FileBasedSystemAccessControl.java
Outdated
Show resolved
Hide resolved
...ugin-toolkit/src/test/java/io/prestosql/plugin/base/security/TestFileBasedAccessControl.java
Outdated
Show resolved
Hide resolved
...oolkit/src/test/java/io/prestosql/plugin/base/security/TestFileBasedSystemAccessControl.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
cleanup-file-access-control
branch
from
db77636 to
f9fa302
Compare
Place check catalog method near other checks
Old camel case names are still supported
Changed file based access control to check for table ownership to create, rename, or drop tables or views.
Only show tables the user has permissions on
If no catalog rules are defined, allow all catalog access
Table and schema default to allow if there are no rules defined, so replace Optional empty with an allow allow rule
System access control defaults to allow if no rules are defined for table, schema, and session property
Catalog file access control is static and not used in combination with other access control systems, so grant and revoke are denied.
dain
force-pushed
the
cleanup-file-access-control
branch
from
f9fa302 to
a4bc95a
Compare
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.