Fix incorrect computation of reader columns for S3SelectRecordCursor#3446
Merged
martint merged 1 commit intotrinodb:masterfrom Apr 16, 2020
Merged
Fix incorrect computation of reader columns for S3SelectRecordCursor#3446martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
martint
approved these changes
Apr 16, 2020
Member
|
I posted #3450 |
Member
|
Tests passed in #3450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @findepi
A couple of tests in hive-tests have been failing with the following stacktrace, since #1720 was checked in.
(These tests are not executed for PRs, since tests in
hive-testsrequire usage ofAWS_ACCESS_KEY_IDdefined in secrets. Right now it looks like the usage of secrets is not allowed for PRs coming from a forked repo. So tests on the PR succeed, but the commits in master are failing these tests.)The stacktrace points to GenericHiveRecordCursor failing to get the first value in
loadedvariable. This indicates that GenericHiveRecordCursor was initialized with 0 columns. (Ref) This seems to happen because of a bug in S3SelectRecordCursorProvider. In case when there is no explicit projection required, an empty list of columns was being used, rather than passing along the input columns.