Ignore already commited transaction during connector metrics collection#29169
Merged
findepi merged 3 commits intotrinodb:masterfrom Apr 20, 2026
Merged
Conversation
The connector metrics collection can fail if the transaction was committed after the check to see if the transaction is active. This is expected, and we should not log an error in this case.
findepi
approved these changes
Apr 20, 2026
Member
findepi
left a comment
There was a problem hiding this comment.
The connector metrics collection can fail if the transaction was committed
This means that connector metrics collection is racing with query finish.
It might be unavoidable, but maybe it's not.
Was there any prior discussion on the topic?
Member
Author
There was some discussion in #26900. Mostly with you. From what I remember, the race is there because of the collection of final query info, and query finish is not synchronized (in general, not in the Java way). |
p3tr0sz
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The connector metrics collection can fail if the
transaction was committed after the check to see if the transaction is active. This is expected, and we should not log an error in this case.
Avoids logs like
Additional context and related issues
Release notes
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: