Skip to content

Remove iceberg.file-based-conflict-detection config property#29147

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-remove-config
Apr 19, 2026
Merged

Remove iceberg.file-based-conflict-detection config property#29147
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-remove-config

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Apr 17, 2026

Description

We introduced this property as a kill switch in February 2025.
This PR removes the property since no issues have been reported for over a year.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot Bot added the cla-signed label Apr 17, 2026
@github-actions github-actions Bot added the iceberg Iceberg connector label Apr 17, 2026
@ebyhr ebyhr force-pushed the ebi/iceberg-remove-config branch from 7e0b81d to 48b61f3 Compare April 17, 2026 05:06
return fileBasedConflictDetectionEnabled;
}

@Config("iceberg.file-based-conflict-detection")
Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Defunct ?

@ebyhr ebyhr force-pushed the ebi/iceberg-remove-config branch from 48b61f3 to a0435d0 Compare April 19, 2026 10:25
@ebyhr ebyhr merged commit 42b9e76 into trinodb:master Apr 19, 2026
46 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-remove-config branch April 19, 2026 11:17
@github-actions github-actions Bot added this to the 481 milestone Apr 19, 2026
@ebyhr ebyhr mentioned this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

2 participants