Add ConnectorSplitAddressProvider in SPI#29138
Open
chenjian2664 wants to merge 3 commits intotrinodb:masterfrom
Open
Add ConnectorSplitAddressProvider in SPI#29138chenjian2664 wants to merge 3 commits intotrinodb:masterfrom
ConnectorSplitAddressProvider in SPI#29138chenjian2664 wants to merge 3 commits intotrinodb:masterfrom
Conversation
github-actions
Bot
added
iceberg
chenjian2664
changed the title
ConnectorSplitAddressProvider in SPI
chenjian2664
force-pushed
the
jack/host-address-provider-spi
branch
3 times, most recently
from
a7255ff to
55134bb
Compare
ebyhr
reviewed
Apr 16, 2026
chenjian2664
force-pushed
the
jack/host-address-provider-spi
branch
4 times, most recently
from
58d9fd5 to
c5de119
Compare
`ConnectorSplit` is intended to be a fully serializable data object from coordinator to workers. Introduce `ConnectorSplitAddressProvider`, supplies `addresses` and `isRemotelyAccessible` at scheduling time on the coordinator, separate from the split data. Also, add the `IcebergSplitAddressProvider` to support in the Iceberg connector.
chenjian2664
force-pushed
the
jack/host-address-provider-spi
branch
from
2fd2516 to
49f0456
Compare
Member
|
Can you move the connector changes to a separate commit from the SPI/engine changes? Also, are the existing methods on |
Member
|
We're working on an alternative to this, its not exactly achieving what I was hoping for |
Member
|
#29182 is the approach i'd like to go with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConnectorSplitis intended to be a fully serializable data objectfrom coordinator to workers. Introduce
ConnectorSplitAddressProvider,supplies
addressesandisRemotelyAccessibleat scheduling time onthe coordinator, separate from the split data.
Also, add the
IcebergSplitAddressProviderto support in the Icebergconnector.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: