Skip to content

Set null to Session.transactionId explicitly when create from other Session#29071

Merged
wendigo merged 1 commit intotrinodb:masterfrom
takezoe:no-copy-session-transaction-id
Apr 11, 2026
Merged

Set null to Session.transactionId explicitly when create from other Session#29071
wendigo merged 1 commit intotrinodb:masterfrom
takezoe:no-copy-session-transaction-id

Conversation

@takezoe
Copy link
Copy Markdown
Member

@takezoe takezoe commented Apr 11, 2026

Description

No need of copying Session.transactionId when it's created from other Session because it's always null as it's checked in advance here:

checkArgument(session.getTransactionId().isEmpty(), "Session builder cannot be created from a session in a transaction");

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 11, 2026
@wendigo wendigo merged commit ec6f0e0 into trinodb:master Apr 11, 2026
96 of 98 checks passed
@github-actions github-actions bot added this to the 481 milestone Apr 11, 2026
@ebyhr ebyhr mentioned this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants