Pass Dynamic Filter to Table Scan when no other filter#29049
Closed
findepi wants to merge 1 commit intotrinodb:masterfrom
Closed
Pass Dynamic Filter to Table Scan when no other filter#29049findepi wants to merge 1 commit intotrinodb:masterfrom
findepi wants to merge 1 commit intotrinodb:masterfrom
Conversation
For a FilterNode above TableScanNode, when filter contains only a dynamic filter, provide the DF to the table scan. Previously the condition to invoke `visitTableScan` helper was only that the `filterExpression` is trivially true. This looked unintentional, as otherwise the `filterExpression` parameter would not be there.
Member
Author
|
i understand now, it was intentional. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a FilterNode above TableScanNode, when filter contains only a dynamic filter, provide the DF to the table scan. Previously the condition to invoke
visitTableScanhelper was only that thefilterExpressionis trivially true. This looked unintentional, as otherwise thefilterExpressionparameter would not be there.