Remove deprecated methods in DateTimeTestingUtils#29017
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Apr 7, 2026
Merged
Conversation
takezoe
force-pushed
the
remove-deprecated-methods-in-date-time-testing-utils
branch
from
372dd77 to
c7787c3
Compare
utafrali
approved these changes
Apr 7, 2026
utafrali
left a comment
utafrali
left a comment
There was a problem hiding this comment.
Clean removal of 4 long-deprecated methods in DateTimeTestingUtils. Both call site migrations are semantically correct: the JDBC test correctly passes precision=3 with 0 nanos (equivalent to the old 0 millis), and the Parquet test explicitly passes precision=3 which matches what the removed method hardcoded internally. No remaining callers of the deleted methods exist in the codebase.
wendigo
approved these changes
Apr 7, 2026
ebyhr
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These methods have been deprecated for 6 years and there are few remaining usages.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: