Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.google.errorprone.annotations.ThreadSafe;
import io.trino.annotation.NotThreadSafe;
import jakarta.annotation.Nullable;

import java.lang.management.ManagementFactory;
import java.lang.management.ThreadMXBean;
Expand Down Expand Up @@ -104,6 +105,18 @@ static class OperationTiming
private final AtomicLong calls = new AtomicLong();
private final AtomicLong wallNanos = new AtomicLong();
private final AtomicLong cpuNanos = new AtomicLong();
@Nullable
private final ResourceUsageTimeSeriesRecorder timeSeriesRecorder;

OperationTiming()
{
this.timeSeriesRecorder = null;
}

OperationTiming(ResourceUsageTimeSeriesRecorder timeSeriesRecorder)
{
this.timeSeriesRecorder = requireNonNull(timeSeriesRecorder, "timeSeriesRecorder is null");
}

long getCalls()
{
Expand All @@ -125,6 +138,9 @@ void record(long wallNanos, long cpuNanos)
this.calls.incrementAndGet();
this.wallNanos.addAndGet(wallNanos);
this.cpuNanos.addAndGet(cpuNanos);
if (timeSeriesRecorder != null) {
timeSeriesRecorder.record(wallNanos, cpuNanos);
}
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.trino.memory.context.LocalMemoryContext;
import io.trino.memory.context.MemoryTrackingContext;
import io.trino.operator.OperationTimer.OperationTiming;
import io.trino.operator.ResourceUsageTimeSeriesRecorder.ResourceUsageTimeSeriesSnapshot;
import io.trino.plugin.base.metrics.TDigestHistogram;
import io.trino.spi.Page;
import io.trino.spi.TrinoException;
Expand Down Expand Up @@ -76,11 +77,12 @@ public class OperatorContext
private final CounterStat internalNetworkInputDataSize = new CounterStat();
private final CounterStat internalNetworkPositions = new CounterStat();

private final OperationTiming addInputTiming = new OperationTiming();
private final ResourceUsageTimeSeriesRecorder cpuTimeSeriesRecorder = new ResourceUsageTimeSeriesRecorder();
private final OperationTiming addInputTiming = new OperationTiming(cpuTimeSeriesRecorder);
private final CounterStat inputDataSize = new CounterStat();
private final CounterStat inputPositions = new CounterStat();

private final OperationTiming getOutputTiming = new OperationTiming();
private final OperationTiming getOutputTiming = new OperationTiming(cpuTimeSeriesRecorder);
private final CounterStat outputDataSize = new CounterStat();
private final CounterStat outputPositions = new CounterStat();

Expand All @@ -97,7 +99,7 @@ public class OperatorContext
private final AtomicReference<ListenableFuture<Void>> finishedFuture = new AtomicReference<>();
private final AtomicLong blockedWallNanos = new AtomicLong();

private final OperationTiming finishTiming = new OperationTiming();
private final OperationTiming finishTiming = new OperationTiming(cpuTimeSeriesRecorder);

private final OperatorSpillContext spillContext;
private final AtomicReference<Supplier<? extends OperatorInfo>> infoSupplier = new AtomicReference<>();
Expand Down Expand Up @@ -560,7 +562,8 @@ public OperatorStats getOperatorStats()
inputPositionsCount,
new Duration(addInputTiming.getCpuNanos() + getOutputTiming.getCpuNanos() + finishTiming.getCpuNanos(), NANOSECONDS).convertTo(SECONDS).getValue(),
new Duration(addInputTiming.getWallNanos() + getOutputTiming.getWallNanos() + finishTiming.getWallNanos(), NANOSECONDS).convertTo(SECONDS).getValue(),
new Duration(blockedWallNanos.get(), NANOSECONDS).convertTo(SECONDS).getValue()),
new Duration(blockedWallNanos.get(), NANOSECONDS).convertTo(SECONDS).getValue(),
cpuTimeSeriesRecorder.snapshot()),
connectorMetrics.get(),
Metrics.EMPTY, // will be filled in when aggregating at pipeline level

Expand All @@ -585,13 +588,19 @@ public OperatorStats getOperatorStats()
info);
}

private Metrics getOperatorMetrics(long inputPositions, double cpuTimeSeconds, double wallTimeSeconds, double blockedWallSeconds)
private Metrics getOperatorMetrics(
long inputPositions,
double cpuTimeSeconds,
double wallTimeSeconds,
double blockedWallSeconds,
ResourceUsageTimeSeriesSnapshot resourceUsageTimeSeries)
{
return metrics.get().mergeWith(new Metrics(ImmutableMap.of(
"Input rows distribution", TDigestHistogram.fromValue(inputPositions),
"CPU time distribution (s)", TDigestHistogram.fromValue(cpuTimeSeconds),
"Scheduled time distribution (s)", TDigestHistogram.fromValue(wallTimeSeconds),
"Blocked time distribution (s)", TDigestHistogram.fromValue(blockedWallSeconds))));
"Blocked time distribution (s)", TDigestHistogram.fromValue(blockedWallSeconds),
"CPU and scheduled time usage over time", resourceUsageTimeSeries)));
}

private static long nanosBetween(long start, long end)
Expand Down
Loading