Skip to content

Add exponential backoff handling for Google Sheets API requests #28985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Apr 6, 2026
Merged

Add exponential backoff handling for Google Sheets API requests #28985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@

import com.google.api.client.auth.oauth2.Credential;
import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
import com.google.api.client.http.HttpBackOffIOExceptionHandler;
import com.google.api.client.http.HttpBackOffUnsuccessfulResponseHandler;
import com.google.api.client.http.HttpRequestInitializer;
import com.google.api.client.json.JsonFactory;
import com.google.api.client.json.jackson2.JacksonFactory;
import com.google.api.client.util.ExponentialBackOff;
import com.google.api.services.sheets.v4.Sheets;
import com.google.api.services.sheets.v4.SheetsScopes;
import com.google.api.services.sheets.v4.model.ValueRange;
Expand Down Expand Up @@ -69,6 +72,13 @@ public class SheetsClient
public static final String RANGE_SEPARATOR = "#";
private static final Logger log = Logger.get(SheetsClient.class);

public static final ExponentialBackOff BACKOFF = new ExponentialBackOff.Builder()
.setInitialIntervalMillis(500)
.setMaxIntervalMillis(10_000)
.setMaxElapsedTimeMillis(60_000)
.setMultiplier(1.5)
.build();

private static final String APPLICATION_NAME = "trino google sheets integration";
private static final JsonFactory JSON_FACTORY = JacksonFactory.getDefaultInstance();

Expand Down Expand Up @@ -333,6 +343,8 @@ private HttpRequestInitializer setTimeout(HttpRequestInitializer requestInitiali
httpRequest.setConnectTimeout(toIntExact(config.getConnectionTimeout().toMillis()));
httpRequest.setReadTimeout(toIntExact(config.getReadTimeout().toMillis()));
httpRequest.setWriteTimeout(toIntExact(config.getWriteTimeout().toMillis()));
httpRequest.setUnsuccessfulResponseHandler(new HttpBackOffUnsuccessfulResponseHandler(BACKOFF));
httpRequest.setIOExceptionHandler(new HttpBackOffIOExceptionHandler(BACKOFF));
};
}
}
5 changes: 5 additions & 0 deletions plugin/trino-google-sheets/src/test/java/io/trino/plugin/google/sheets/TestGoogleSheets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
package io.trino.plugin.google.sheets;

import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
import com.google.api.client.http.HttpBackOffIOExceptionHandler;
import com.google.api.client.http.HttpBackOffUnsuccessfulResponseHandler;
import com.google.api.client.http.HttpRequestInitializer;
import com.google.api.client.json.jackson2.JacksonFactory;
import com.google.api.services.sheets.v4.Sheets;
Expand All @@ -36,6 +38,7 @@
import java.util.concurrent.TimeUnit;

import static com.google.api.client.googleapis.javanet.GoogleNetHttpTransport.newTrustedTransport;
import static io.trino.plugin.google.sheets.SheetsClient.BACKOFF;
import static io.trino.plugin.google.sheets.TestSheetsPlugin.DATA_SHEET_ID;
import static io.trino.plugin.google.sheets.TestSheetsPlugin.getTestCredentialsPath;
import static io.trino.testing.assertions.Assert.assertEventually;
Expand Down Expand Up @@ -329,6 +332,8 @@ private static HttpRequestInitializer setTimeout(HttpRequestInitializer requestI
requestInitializer.initialize(httpRequest);
httpRequest.setConnectTimeout(toIntExact(TimeUnit.MINUTES.toMillis(1)));
httpRequest.setReadTimeout(toIntExact(TimeUnit.MINUTES.toMillis(1)));
httpRequest.setUnsuccessfulResponseHandler(new HttpBackOffUnsuccessfulResponseHandler(BACKOFF));
httpRequest.setIOExceptionHandler(new HttpBackOffIOExceptionHandler(BACKOFF));
};
}
}