VARIANT code cleanups and improvements#28939
Merged
Conversation
wendigo
force-pushed
the
user/serafin/variant-fixes-and-improvements
branch
from
f47798c to
b2fa813
Compare
wendigo
force-pushed
the
user/serafin/variant-fixes-and-improvements
branch
from
b2fa813 to
e2cc8f9
Compare
dain
reviewed
Mar 31, 2026
Member
dain
left a comment
dain
left a comment
There was a problem hiding this comment.
Other than the last commit this looks good
| generator.copyCurrentStructure(parser); | ||
| } | ||
| return writer.toString(); | ||
| return JSON_MAPPER.writeValueAsString(JSON_MAPPER.readTree(parser)); |
Member
There was a problem hiding this comment.
I think this is a lot more expensive. The old code, had a parser copying tokens directly into a generator, and I think the new code creates a JsonNode, which is a big object graph.
Contributor
Author
There was a problem hiding this comment.
Partially reverted. PTAL
wendigo
force-pushed
the
user/serafin/variant-fixes-and-improvements
branch
from
e2cc8f9 to
1efa7cb
Compare
Contributor
Author
|
@dain PTAL |
dain
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: