Skip to content

Fail on trailing content after JSON null in CAST#28932

Merged
findepi merged 3 commits intotrinodb:masterfrom
findepi:findepi/fail-on-trailing-content-after-json-null-in-cast-e50835
Mar 31, 2026
Merged

Fail on trailing content after JSON null in CAST#28932
findepi merged 3 commits intotrinodb:masterfrom
findepi:findepi/fail-on-trailing-content-after-json-null-in-cast-e50835

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Mar 30, 2026

When casting invalid JSON to array, map or row, content invalidity should result in failure.

Also includes a regression test guarding against this:

When casting invalid JSON to array, map or row, content invalidity
should result in failure.
@findepi findepi requested review from dain, losipiuk and wendigo March 30, 2026 16:49
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Mar 30, 2026
@cla-bot cla-bot bot added the cla-signed label Mar 30, 2026
findepi added 2 commits March 30, 2026 18:49
- add test cases with numbers with leading/trailing zeros.
- verify that casting string -> JSON -> array(varchar) and an optimized
  path behave the same.
@findepi findepi merged commit ed4623a into trinodb:master Mar 31, 2026
100 checks passed
@findepi findepi deleted the findepi/fail-on-trailing-content-after-json-null-in-cast-e50835 branch March 31, 2026 07:10
@github-actions github-actions bot added this to the 481 milestone Mar 31, 2026
@ebyhr ebyhr mentioned this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

Trailing content after null ignored when casting json_parse result to array or map

2 participants