Merged
Conversation
findepi
reviewed
Mar 30, 2026
wendigo
force-pushed
the
user/serafin/python-udf-number
branch
2 times, most recently
from
ac94020 to
94eec10
Compare
wendigo
force-pushed
the
user/serafin/python-udf-number
branch
from
94eec10 to
bba163e
Compare
Contributor
Author
|
@findepi switched to dedicated NUMBER type (23) |
wendigo
commented
Mar 30, 2026
|
|
||
| assertThat(assertions.query( | ||
| query + "SELECT multiply(NUMBER '+Infinity', NUMBER '-Infinity')")) | ||
| .matches("VALUES NUMBER '-Infinity'"); |
Contributor
Author
There was a problem hiding this comment.
This is according to python :)
Contributor
Author
There was a problem hiding this comment.
>>> import decimal
>>> decimal.Decimal('Infinity') * decimal.Decimal('-Infinity')
Decimal('-Infinity')
bba163e to
868aa1f
Compare
wendigo
force-pushed
the
user/serafin/python-udf-number
branch
from
868aa1f to
7c8d87a
Compare
findepi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitted after accidental merge
Description
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: