Skip to content

Remove unused write type from DeltaLakeTableHandle#28913

Merged
chenjian2664 merged 2 commits intotrinodb:masterfrom
chenjian2664:jack/rm-unused-write-type-delta
Mar 31, 2026
Merged

Remove unused write type from DeltaLakeTableHandle#28913
chenjian2664 merged 2 commits intotrinodb:masterfrom
chenjian2664:jack/rm-unused-write-type-delta

Conversation

@chenjian2664
Copy link
Copy Markdown
Contributor

Description

The write type UPDATE and DELETE are not used anywhere

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 30, 2026
@github-actions github-actions bot added the delta-lake Delta Lake connector label Mar 30, 2026
@chenjian2664 chenjian2664 requested review from Copilot, ebyhr and findinpath and removed request for Copilot and ebyhr March 30, 2026 04:21
@chenjian2664 chenjian2664 requested a review from ebyhr March 30, 2026 04:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the Delta Lake connector’s DeltaLakeTableHandle by removing unused write-type variants and associated unused handle fields, and updates production/test call sites to match the new constructor/shape.

Changes:

  • Removed UPDATE/DELETE from DeltaLakeTableHandle.WriteType.
  • Removed unused updatedColumns / updateRowIdColumns fields and their JSON properties/accessors from DeltaLakeTableHandle.
  • Updated DeltaLakeMetadata and multiple tests to use the updated DeltaLakeTableHandle constructors/APIs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeTableHandle.java Removes unused write types and update-related columns from the handle; updates constructor/serialization accordingly.
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java Adjusts DeltaLakeTableHandle instantiations to the new constructor signature.
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/statistics/TestDeltaLakeFileBasedTableStatisticsProvider.java Updates test handle construction and usage to removed handle fields.
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestingDeltaLakeUtils.java Updates test utility handle construction to match new signature.
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestTransactionLogAccess.java Updates test handle construction to match new signature.
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java Updates test handle construction to match new signature.
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeNodeLocalDynamicSplitPruning.java Updates test handle construction to match new signature.
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMetadata.java Updates helper handle construction to remove references to removed write types/fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was thinking the same fix in my previous PR, but I was lazy.

Comment on lines -44 to -45
UPDATE,
DELETE
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of having an enum with one value?

Consider using a boolean field with a meaningful name instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added eafc80b

@chenjian2664 chenjian2664 force-pushed the jack/rm-unused-write-type-delta branch from eafc80b to ee63a6a Compare March 30, 2026 11:11
@chenjian2664 chenjian2664 merged commit 68971b6 into trinodb:master Mar 31, 2026
26 checks passed
@chenjian2664 chenjian2664 deleted the jack/rm-unused-write-type-delta branch March 31, 2026 03:10
@github-actions github-actions bot added this to the 481 milestone Mar 31, 2026
@ebyhr ebyhr mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed delta-lake Delta Lake connector

Development

Successfully merging this pull request may close these issues.

5 participants