Remove unused write type from DeltaLakeTableHandle#28913
Merged
chenjian2664 merged 2 commits intotrinodb:masterfrom Mar 31, 2026
Merged
Remove unused write type from DeltaLakeTableHandle#28913chenjian2664 merged 2 commits intotrinodb:masterfrom
DeltaLakeTableHandle#28913chenjian2664 merged 2 commits intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Delta Lake connector’s DeltaLakeTableHandle by removing unused write-type variants and associated unused handle fields, and updates production/test call sites to match the new constructor/shape.
Changes:
- Removed
UPDATE/DELETEfromDeltaLakeTableHandle.WriteType. - Removed unused
updatedColumns/updateRowIdColumnsfields and their JSON properties/accessors fromDeltaLakeTableHandle. - Updated
DeltaLakeMetadataand multiple tests to use the updatedDeltaLakeTableHandleconstructors/APIs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeTableHandle.java | Removes unused write types and update-related columns from the handle; updates constructor/serialization accordingly. |
| plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java | Adjusts DeltaLakeTableHandle instantiations to the new constructor signature. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/statistics/TestDeltaLakeFileBasedTableStatisticsProvider.java | Updates test handle construction and usage to removed handle fields. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestingDeltaLakeUtils.java | Updates test utility handle construction to match new signature. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestTransactionLogAccess.java | Updates test handle construction to match new signature. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java | Updates test handle construction to match new signature. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeNodeLocalDynamicSplitPruning.java | Updates test handle construction to match new signature. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMetadata.java | Updates helper handle construction to remove references to removed write types/fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ebyhr
approved these changes
Mar 30, 2026
Member
ebyhr
left a comment
There was a problem hiding this comment.
Thanks, I was thinking the same fix in my previous PR, but I was lazy.
findinpath
reviewed
Mar 30, 2026
Comment on lines
-44
to
-45
| UPDATE, | ||
| DELETE |
Contributor
There was a problem hiding this comment.
What is the purpose of having an enum with one value?
Consider using a boolean field with a meaningful name instead
wendigo
approved these changes
Mar 30, 2026
eafc80b to
ee63a6a
Compare
findinpath
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The write type
UPDATEandDELETEare not used anywhereAdditional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: