Fix wrong test invocation in Iceberg BigLake#28912
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a unit test override in the Iceberg BigLake REST catalog smoke tests where the wrong superclass test method was being invoked, ensuring the intended BigLake-specific behavior is actually exercised.
Changes:
- Corrects the overridden test to call
super::testRegisterTableWithTrailingSpaceInLocationinstead of the different-table-name variant. - Updates the expected failure assertions to match the actual failure mode encountered in BigLake for trailing-space locations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
findepi
approved these changes
Mar 30, 2026
chenjian2664
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.