Skip to content

Propagate split source metrics to QueryInputMetadata#28871

Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom
kekwan:input-metadata-split-source
Apr 5, 2026
Merged

Propagate split source metrics to QueryInputMetadata#28871
raunaqmorarka merged 1 commit intotrinodb:masterfrom
kekwan:input-metadata-split-source

Conversation

@kekwan
Copy link
Copy Markdown
Contributor

@kekwan kekwan commented Mar 26, 2026

Description

Fixes #28870

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Event Listener
* Include connector split source metrics in io.trino.spi.eventlistener.QueryInputMetadata#connectorMetrics. ({issue}`28870`)

Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test in TestEventListenerBasic ?
change looks ok to me

@kekwan kekwan force-pushed the input-metadata-split-source branch from 6dc2902 to edb0f48 Compare March 30, 2026 20:48
@kekwan kekwan force-pushed the input-metadata-split-source branch from edb0f48 to 56ec6af Compare March 30, 2026 20:49
@kekwan kekwan requested a review from raunaqmorarka March 30, 2026 20:49
@kekwan
Copy link
Copy Markdown
Contributor Author

kekwan commented Mar 30, 2026

can you add a test in TestEventListenerBasic ? change looks ok to me

Added, thanks

@raunaqmorarka
Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6eb09ef6-2175-4bfb-bb57-21d86cc338d6

📥 Commits

Reviewing files that changed from the base of the PR and between a4e2d12 and 56ec6af.

📒 Files selected for processing (4)
  • core/trino-main/src/main/java/io/trino/event/QueryMonitor.java
  • core/trino-main/src/test/java/io/trino/connector/MockConnector.java
  • core/trino-main/src/test/java/io/trino/connector/MockConnectorFactory.java
  • testing/trino-tests/src/test/java/io/trino/execution/TestEventListenerBasic.java

📝 Walkthrough

Walkthrough

The pull request modifies the QueryMonitor.extractPlanNodeStats method to merge split source metrics from stageInfo.stageStats().getSplitSourceMetrics() into the operator summaries before mapping them to plan nodes. The changes include test infrastructure enhancements to MockConnector and MockConnectorFactory to support split source metrics configuration, and a test update to validate the merged metrics are correctly included in connector metrics assertions.

Assessment against linked issues

Objective Addressed Explanation
Include split source metrics in QueryInputMetadata.getConnectorMetrics() by merging them in QueryMonitor.getQueryIOMetadata() [#28870]

Out-of-scope changes

No out-of-scope changes detected. All modifications directly support the objective of incorporating split source metrics into QueryInputMetadata.getConnectorMetrics() through the QueryMonitor implementation and corresponding test infrastructure.


Comment @coderabbitai help to get the list of available commands and usage tips.

@raunaqmorarka raunaqmorarka merged commit eec8926 into trinodb:master Apr 5, 2026
194 of 196 checks passed
@github-actions github-actions bot added this to the 481 milestone Apr 5, 2026
@ebyhr ebyhr mentioned this pull request Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

ConnectorSplitSource Metrics missing in QueryInputMetadata connectorMetrics

2 participants