Do not fail when HMS returns new stats types#28833
Merged
findepi merged 2 commits intotrinodb:masterfrom Mar 25, 2026
Merged
Conversation
wendigo
approved these changes
Mar 24, 2026
anton-kutuzov
approved these changes
Mar 24, 2026
raunaqmorarka
approved these changes
Mar 24, 2026
Contributor
|
@findepi this is orthogonal to the other fix so could be merged as well, right? |
findepi
added
the
no-release-notes
findinpath
reviewed
Mar 25, 2026
| } | ||
| throw new TrinoException(HIVE_INVALID_METADATA, "Invalid column statistics data: " + columnStatistics); | ||
| log.warn("Unsupported column statistics data: %s", columnStatistics); | ||
| return new HiveColumnStatistics( |
Contributor
There was a problem hiding this comment.
Pls add test coverage in io.trino.plugin.hive.metastore.thrift.TestThriftMetastoreUtil
Member
Author
There was a problem hiding this comment.
It's covered by product test. I will need your help with more coverage. Do you want to take over this PR?
findinpath
reviewed
Mar 25, 2026
| nullsCount); | ||
| } | ||
| throw new TrinoException(HIVE_INVALID_METADATA, "Invalid column statistics data: " + columnStatistics); | ||
| log.warn("Unsupported column statistics data: %s", columnStatistics); |
Contributor
There was a problem hiding this comment.
It would be worthwhile to have the schema and table name to locate the table in the data lake that is generating this log statement.
findepi
force-pushed
the
findepi/do-not-fail-when-hms-returns-new-stats-types-3bee6a
branch
2 times, most recently
from
9f6feaf to
e4a4e29
Compare
findinpath
approved these changes
Mar 25, 2026
findepi
force-pushed
the
findepi/do-not-fail-when-hms-returns-new-stats-types-3bee6a
branch
from
e4a4e29 to
0c24f5a
Compare
HMS API can evolve. Adding new statistics type should be a backwards compatible change. Inability to infer statistics for such column is better than failing.
findepi
force-pushed
the
findepi/do-not-fail-when-hms-returns-new-stats-types-3bee6a
branch
from
0c24f5a to
b3c671e
Compare
findepi
deleted the
findepi/do-not-fail-when-hms-returns-new-stats-types-3bee6a
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HMS API can evolve. Adding new statistics type should be a backwards compatible change. Inability to infer statistics for such column is better than failing.