Allow to store externalAuthenticationToken in SYSTEM Cache#28783
Merged
kokosing merged 2 commits intotrinodb:masterfrom Apr 1, 2026
Merged
Allow to store externalAuthenticationToken in SYSTEM Cache#28783kokosing merged 2 commits intotrinodb:masterfrom
kokosing merged 2 commits intotrinodb:masterfrom
Conversation
Contributor
|
What if I want to authenticate as two different users in the two different CLIs? |
Contributor
Author
|
The same question as |
kokosing
reviewed
Mar 20, 2026
Member
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
Can you please add tests to io.trino.client.auth.external.TestExternalAuthenticator?
ssheikin
force-pushed
the
ssheikin/43/trino/cli-cache-token-SYSTEM
branch
from
0d64d60 to
3b0c061
Compare
ssheikin
force-pushed
the
ssheikin/43/trino/cli-cache-token-SYSTEM
branch
2 times, most recently
from
d0f021b to
929a1e3
Compare
kokosing
approved these changes
Mar 25, 2026
Contributor
Author
|
@wendigo @lukasz-walkiewicz would you like to take another glance here? |
Contributor
|
not an expert here so just, ack. |
(in dotfiles), so it can be reused between processes, without requiring authentication. This may be helpful in case different CLI are run from the same machine.
Storing tokens cached within system deals with filesystem, where delays are much more significant than in-memory. Increasing to 100 concurrent transaction increases the overall execution time, thus, also increasing timeout for a test method.
ssheikin
force-pushed
the
ssheikin/43/trino/cli-cache-token-SYSTEM
branch
from
929a1e3 to
2f14893
Compare
Contributor
Author
|
Is it a good time to move forward with this PR? |
kokosing
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(in dotfiles),
so it can be reused between processes, without requiring authentication. This may be helpful in case different CLI are run from the same machine.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: