Skip to content

Move spilling join operator classes to subpackage #28369

Merged
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/spilllllling
Feb 19, 2026
Merged

Move spilling join operator classes to subpackage #28369
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/spilllllling

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Feb 19, 2026

A bunch of join operator classes are duplicated since
98991ac commit (#12618). However, the naming and
packaging is ambiguous. Remove ambiguity by moving classes specific to
spilling join to a subpackage, just like we have subpackage for
classes specific to non-spilling join.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Feb 19, 2026
@cla-bot cla-bot bot added the cla-signed label Feb 19, 2026
A bunch of join operator classes are duplicated since
98991ac commit. However, the naming and
packaging is ambiguous. Remove ambiguity by moving classes specific to
spilling join to a subpackage, just like we have subpackage for
classes specific to non-spilling join.
It's shared between spilling and non-spilling Join operators. Moved to
shared place.
@findepi findepi force-pushed the findepi/spilllllling branch from ef8dfd4 to f0a1188 Compare February 19, 2026 12:03
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Feb 19, 2026

rebased to resolve code conflict

@findepi findepi merged commit 8cc218d into trinodb:master Feb 19, 2026
100 checks passed
@findepi findepi deleted the findepi/spilllllling branch February 19, 2026 12:57
@github-actions github-actions bot added this to the 480 milestone Feb 19, 2026
@ebyhr ebyhr mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants