Move spilling join operator classes to subpackage #28369
Merged
findepi merged 2 commits intotrinodb:masterfrom Feb 19, 2026
Merged
Move spilling join operator classes to subpackage #28369findepi merged 2 commits intotrinodb:masterfrom
findepi merged 2 commits intotrinodb:masterfrom
Conversation
losipiuk
approved these changes
Feb 19, 2026
A bunch of join operator classes are duplicated since 98991ac commit. However, the naming and packaging is ambiguous. Remove ambiguity by moving classes specific to spilling join to a subpackage, just like we have subpackage for classes specific to non-spilling join.
It's shared between spilling and non-spilling Join operators. Moved to shared place.
ef8dfd4 to
f0a1188
Compare
Member
Author
|
rebased to resolve code conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of join operator classes are duplicated since
98991ac commit (#12618). However, the naming and
packaging is ambiguous. Remove ambiguity by moving classes specific to
spilling join to a subpackage, just like we have subpackage for
classes specific to non-spilling join.