Prefer spilling in window fullGroupBuffered when there was at least one spill#27873
Merged
sopel39 merged 2 commits intotrinodb:masterfrom Jan 12, 2026
Merged
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Karol Sobczak.
|
Revocable memory needs to be converted to user memory as producing output stage is no longer revocable.
When spill happened, prefer spilling rather than merging with memory. This prevents query node-level OOM when query is spill heavy.
d025203 to
8bd42d4
Compare
raunaqmorarka
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When spill happened, prefer spilling rather than merging with memory.
This prevents query node-level OOM when query is spill heavy
Additionally, a minor bug was fixed in spoilable hash aggregation, when removable memory
was not covered to user memory when merge with memory happens
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Fixes #10596