Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: hmc7491871.
|
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
chenjian2664
left a comment
There was a problem hiding this comment.
Could you add the connector tests?
plugin/trino-tibero/src/main/java/io/trino/plugin/tibero/TiberoClient.java
Show resolved
Hide resolved
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@chenjian2664
Please review and let me know if any further adjustments are needed. |
90fc42e to
83d0233
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
83d0233 to
a367b8f
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1 similar comment
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@thehkkim Have you signed cla yet - suggested by the cla-bot? |
|
@chenjian2664 Additionally, this PR was originally labeled only as |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
Hi @martint, I submitted my CLA to cla@trino.io on January 9th with the subject "Signed CLA for Trino - GitHub user thehkkim". My email address is thehkkim@gmail.com. Could you help me verify the status of my CLA submission? Thank you! |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
@martint
Could you please verify the status of my CLA submission? |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
229dc53 to
fbaa344
Compare
5f189d4 to
5806614
Compare
Add a new Tibero connector that allows querying and creating tables in an external Tibero database. The connector is based on the JDBC connector framework and supports standard SQL operations. The Tibero JDBC driver (tibero7-jdbc.jar) is not bundled with the plugin because it is not available in public Maven repositories. Users must obtain the driver from TmaxSoft and place it in the plugin directory manually. Co-Authored-By: thehkkim <thehkkim@gmail.com>
5806614 to
39404da
Compare
|
Hi @chenjian2664, It seems that some extra labels were added unintentionally due to a previous incorrect merge. Only the cla-signed and docs labels should remain — could you help remove the other labels? Also, is there anything else I need to do on my end? Please let me know if any further action is required. |
|
@thehkkim Could you add a connector test, you can refer |
Description
This PR adds a new JDBC connector for Tibero database. Tibero is an enterprise-grade relational database management system that is Oracle-compatible and widely used in enterprise environments.
The connector extends
BaseJdbcClientand provides:Additional context and related issues
The implementation follows the same pattern as other JDBC connectors in Trino (e.g., Oracle, PostgreSQL). The connector handles Tibero's type system including:
Note: The connector uses a system-scoped JDBC driver dependency which needs to be configured with the actual Tibero JDBC driver location.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: