Skip to content

Feature/tibero connector#27854

Open
thehkkim wants to merge 1 commit intotrinodb:masterfrom
thehkkim:feature/tibero-connector
Open

Feature/tibero connector#27854
thehkkim wants to merge 1 commit intotrinodb:masterfrom
thehkkim:feature/tibero-connector

Conversation

@thehkkim
Copy link
Copy Markdown

@thehkkim thehkkim commented Jan 6, 2026

Description

This PR adds a new JDBC connector for Tibero database. Tibero is an enterprise-grade relational database management system that is Oracle-compatible and widely used in enterprise environments.

The connector extends BaseJdbcClient and provides:

  • Support for common SQL data types (numeric, character, timestamp, binary)
  • Tibero-specific type mappings for DATE and TIMESTAMP types with precision up to 9
  • Proper handling of B.C. dates (year adjustment)
  • Type conversion handling for CLOB, NCLOB, BLOB, and RAW types

Additional context and related issues

The implementation follows the same pattern as other JDBC connectors in Trino (e.g., Oracle, PostgreSQL). The connector handles Tibero's type system including:

  • Numeric types: SMALLINT, INTEGER, BIGINT, REAL, DOUBLE, DECIMAL/NUMERIC
  • Character types: CHAR, VARCHAR, NVARCHAR, CLOB, NCLOB
  • Binary types: VARBINARY (RAW), BLOB
  • Temporal types: DATE, TIMESTAMP with nanosecond precision

Note: The connector uses a system-scoped JDBC driver dependency which needs to be configured with the actual Tibero JDBC driver location.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## JDBC
* Add support for Tibero database connector.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 6, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: hmc7491871.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the docs label Jan 6, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 6, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Copy Markdown
Contributor

@chenjian2664 chenjian2664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the connector tests?

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 8, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@thehkkim
Copy link
Copy Markdown
Author

thehkkim commented Jan 8, 2026

@chenjian2664
Thank you for the detailed review and feedback. I've made the following updates:

  • Enhanced documentation
  • Added type mapping tests

Please review and let me know if any further adjustments are needed.

@thehkkim thehkkim force-pushed the feature/tibero-connector branch from 90fc42e to 83d0233 Compare January 8, 2026 15:13
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 8, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added release-notes ui Web UI hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector druid Druid connector exasol Exasol connector ignite Ignite connector kafka Kafka connector loki Loki connector mysql MySQL connector opensearch OpenSearch connector pinot Pinot connector postgresql PostgreSQL connector prometheus Prometheus connector redshift Redshift connector singlestore SingleStore connector sqlserver SQLServer connector lakehouse labels Jan 8, 2026
@thehkkim thehkkim force-pushed the feature/tibero-connector branch from 83d0233 to a367b8f Compare January 8, 2026 15:20
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 8, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 14, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@chenjian2664
Copy link
Copy Markdown
Contributor

@thehkkim Have you signed cla yet - suggested by the cla-bot?

@thehkkim
Copy link
Copy Markdown
Author

thehkkim commented Jan 14, 2026

@chenjian2664
Yes, I have already signed the CLA and sent it to cla@trino.io on Jan 9.
I re-sent the signed CLA because the previous email had an incorrect subject. Thanks!

Additionally, this PR was originally labeled only as docs.
It seems that some additional labels were added after an intermediate commit.
Would it be possible to keep only the docs label?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Feb 4, 2026
@thehkkim
Copy link
Copy Markdown
Author

thehkkim commented Feb 6, 2026

Hi @martint,

I submitted my CLA to cla@trino.io on January 9th with the subject "Signed CLA for Trino - GitHub user thehkkim". My email address is thehkkim@gmail.com.

Could you help me verify the status of my CLA submission?

Thank you!

@github-actions github-actions bot removed the stale label Feb 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Mar 2, 2026
@thehkkim
Copy link
Copy Markdown
Author

thehkkim commented Mar 3, 2026

@martint
Thank you for your email!
I've resubmitted the CLA with a proper handwritten signature as you suggested.

  • the subject : Signed CLA for Trino - GitHub user thehkkim
  • My email address : thehkkim@gmail.com

Could you please verify the status of my CLA submission?

@chenjian2664
Copy link
Copy Markdown
Contributor

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 3, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 3, 2026

The cla-bot has been summoned, and re-checked this pull request!

@github-actions github-actions bot removed the stale label Mar 3, 2026
@thehkkim thehkkim force-pushed the feature/tibero-connector branch from 229dc53 to fbaa344 Compare March 25, 2026 06:54
@cla-bot cla-bot bot added the cla-signed label Mar 25, 2026
@thehkkim thehkkim force-pushed the feature/tibero-connector branch 7 times, most recently from 5f189d4 to 5806614 Compare March 26, 2026 04:28
Add a new Tibero connector that allows querying and creating tables in
an external Tibero database. The connector is based on the JDBC connector
framework and supports standard SQL operations.

The Tibero JDBC driver (tibero7-jdbc.jar) is not bundled with the plugin
because it is not available in public Maven repositories. Users must obtain
the driver from TmaxSoft and place it in the plugin directory manually.

Co-Authored-By: thehkkim <thehkkim@gmail.com>
@thehkkim thehkkim force-pushed the feature/tibero-connector branch from 5806614 to 39404da Compare March 27, 2026 02:27
@thehkkim
Copy link
Copy Markdown
Author

Hi @chenjian2664,

It seems that some extra labels were added unintentionally due to a previous incorrect merge. Only the cla-signed and docs labels should remain — could you help remove the other labels?

Also, is there anything else I need to do on my end? Please let me know if any further action is required.
Thank you! 🙏

@chenjian2664
Copy link
Copy Markdown
Contributor

@thehkkim Could you add a connector test, you can refer TestOracleConnectorTest.
Once tests are added, my main question is, do you have a plan for how they'll be executed, and who will cover the ci testing costs(bill)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery BigQuery connector cla-signed delta-lake Delta Lake connector docs druid Druid connector exasol Exasol connector hive Hive connector hudi Hudi connector iceberg Iceberg connector ignite Ignite connector kafka Kafka connector lakehouse loki Loki connector mysql MySQL connector opensearch OpenSearch connector pinot Pinot connector postgresql PostgreSQL connector prometheus Prometheus connector redshift Redshift connector singlestore SingleStore connector sqlserver SQLServer connector ui Web UI

Development

Successfully merging this pull request may close these issues.

3 participants