Skip to content

Update React#27632

Merged
wendigo merged 1 commit intotrinodb:masterfrom
simpligility:preview-react-fis
Jan 22, 2026
Merged

Update React#27632
wendigo merged 1 commit intotrinodb:masterfrom
simpligility:preview-react-fis

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Dec 12, 2025

Description

Preventative measure to avoid alerts from the recent React security issues. See https://www.youtube.com/watch?v=NEWgj-KP4Sg

Tested now - works fine. Update to 19.2 can be done later

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Dec 12, 2025
@github-actions github-actions bot added the ui Web UI label Dec 12, 2025
@wendigo wendigo requested a review from koszti December 12, 2025 14:15
Copy link
Copy Markdown
Member

@koszti koszti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Jan 5, 2026
@mosabua mosabua changed the title (WIP) Update React Update React Jan 10, 2026
@koszti
Copy link
Copy Markdown
Member

koszti commented Jan 10, 2026

should we consider using regular npm audit fix instead of bumping vulnerable packages one by one? - somewhat related to #27869

@koszti koszti mentioned this pull request Jan 10, 2026
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Jan 10, 2026

should we consider using regular npm audit fix instead of bumping vulnerable packages one by one? - somewhat related to #27869

I think we want to do that eventually ...  maybe after merging this PR already ... the only thing with these larger PRs that update a lot is that it is harder to test to some degree and also to figure out the right release notes entry (if any). And they might carry more related code changes as well

@github-actions github-actions bot removed the stale label Jan 12, 2026
@mosabua mosabua requested review from dain and wendigo January 15, 2026 05:04
@wendigo wendigo merged commit c496769 into trinodb:master Jan 22, 2026
196 of 198 checks passed
@github-actions github-actions bot added this to the 480 milestone Jan 22, 2026
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jan 22, 2026

Hmm, package-lock.json is different from a file I built locally.

@mosabua mosabua deleted the preview-react-fis branch January 23, 2026 02:01
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Jan 23, 2026

Hmm, package-lock.json is different from a file I built locally.

With new releases out, the lock file will change most likely. Ideally we update more often .. there is a separate PR for that somewhere. I purposely limited the changes in this PR.

Also thanks for merge @wendigo

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jan 23, 2026

@mosabua I don't follow. The different package-lock.json means we have to revert the change before sending a PR. I updated the file in #27986.

@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Jan 24, 2026

Thanks for the follow up @ebyhr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants