Apache DataSketches plugin for Trino#27563
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Mar 16, 2026
Merged
Conversation
sopel39
force-pushed
the
ks/data_sketches
branch
from
e892109 to
09190ed
Compare
martint
previously requested changes
Dec 5, 2025
...ino-datasketches/src/main/java/io/trino/plugin/datasketches/theta/SketchFunctionsPlugin.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Dec 8, 2025
findepi
reviewed
Dec 8, 2025
plugin/trino-datasketches/src/main/java/io/trino/plugin/datasketches/theta/UnionWithParams.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Dec 8, 2025
plugin/trino-datasketches/src/main/java/io/trino/plugin/datasketches/theta/UnionWithParams.java
Show resolved
Hide resolved
findepi
reviewed
Dec 8, 2025
sopel39
force-pushed
the
ks/data_sketches
branch
from
09190ed to
497b043
Compare
findepi
reviewed
Dec 10, 2025
plugin/trino-datasketches/src/test/java/io/trino/plugin/datasketches/TestDataSketches.java
Show resolved
Hide resolved
...n/trino-datasketches/src/test/java/io/trino/plugin/datasketches/theta/TestMergeEstimate.java
Outdated
Show resolved
Hide resolved
plugin/trino-datasketches/src/main/java/io/trino/plugin/datasketches/theta/UnionWithParams.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Dec 10, 2025
...ino-datasketches/src/main/java/io/trino/plugin/datasketches/state/SketchStateSerializer.java
Outdated
Show resolved
Hide resolved
mosabua
requested changes
Dec 15, 2025
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Mostly good to go. Left some minor comments. Main one is to address the installation/use better.
sopel39
force-pushed
the
ks/data_sketches
branch
from
497b043 to
e606195
Compare
sopel39
force-pushed
the
ks/data_sketches
branch
2 times, most recently
from
18d77cc to
9a6d352
Compare
mosabua
requested changes
Jan 7, 2026
sopel39
force-pushed
the
ks/data_sketches
branch
from
9a6d352 to
febdc98
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
mosabua
added
the
stale-ignore
Member
wendigo
reviewed
Jan 30, 2026
martint
reviewed
Feb 12, 2026
plugin/trino-datasketches/src/test/java/io/trino/plugin/datasketches/TestDataSketches.java
Outdated
Show resolved
Hide resolved
plugin/trino-datasketches/src/main/java/io/trino/plugin/datasketches/theta/Estimate.java
Outdated
Show resolved
Hide resolved
plugin/trino-datasketches/src/main/java/io/trino/plugin/datasketches/theta/Estimate.java
Show resolved
Hide resolved
sopel39
force-pushed
the
ks/data_sketches
branch
from
febdc98 to
94efac4
Compare
sopel39
force-pushed
the
ks/data_sketches
branch
from
94efac4 to
3475e61
Compare
wendigo
force-pushed
the
ks/data_sketches
branch
from
3475e61 to
486bffb
Compare
wendigo
approved these changes
Feb 24, 2026
.../trino-datasketches/src/main/java/io/trino/plugin/datasketches/state/SketchStateFactory.java
Outdated
Show resolved
Hide resolved
...ino-datasketches/src/main/java/io/trino/plugin/datasketches/state/SketchStateSerializer.java
Outdated
Show resolved
Hide resolved
Plugin to query Apache DataSketches (https://datasketches.apache.org/docs/Theta/ThetaSketchFramework.html). This includes merge and estimate function for theta sketch.
sopel39
force-pushed
the
ks/data_sketches
branch
from
486bffb to
4f9a61e
Compare
Member
Author
|
Thanks for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin to query Apache DataSketches (https://datasketches.apache.org/docs/Theta/ThetaSketchFramework.html). This includes merge and estimate function for theta sketch.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Supercedes #6643