WIP: Add uuid_v6 and uuid_v7 functions #27493
Open
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before I start adding tests and whatnot, let's agree on naming first. @martint can you take a look? |
findepi
reviewed
Nov 28, 2025
| @Constraint(variable = "u", expression = "min(u, 6)") | ||
| public static Slice uuid_v6(@SqlType("timestamp(u) with time zone") long rawTimestamp) | ||
| { | ||
| java.util.UUID uuid = V6_GENERATOR.construct(rawTimestamp); |
Member
There was a problem hiding this comment.
I doubt com.fasterxml.uuid.impl.TimeBasedEpochRandomGenerator knows the structure of trino timestamp tz values
Comment on lines
+68
to
+69
| @Constraint(variable = "u", expression = "min(u, 6)") | ||
| public static Slice uuid_v6(@SqlType("timestamp(u) with time zone") long rawTimestamp) |
Member
There was a problem hiding this comment.
That results in a rather nasty exception
trino> select uuid_v6( current_timestamp(9) );
Query 20251128_140821_00027_837vf failed: variable 'u' is already set to 9 when trying to set 6
java.lang.IllegalStateException: variable 'u' is already set to 9 when trying to set 6
Engine is not supposed to throw anything other than TrinoExceptions.
Comment on lines
+64
to
+65
| @Description("Generates a random UUID v6 from a given timestamp (RFC-9562)") | ||
| @ScalarFunction |
Member
There was a problem hiding this comment.
Provide explicit deterministic declaration.
Member
There was a problem hiding this comment.
BTW this function looks deterministic. What's the use-case to have it?
| public static Slice uuid() | ||
| { | ||
| java.util.UUID uuid = randomUUID(); | ||
| java.util.UUID uuid = V4_GENERATOR.generate(); |
Member
There was a problem hiding this comment.
Is this better, different, or same as randomUUID the code used to use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: