Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Oct 23, 2025

Summary by Sourcery

Add placeholder modifications to the Black Hole connector docs and code to verify CI integration.

Chores:

  • Add a note in the Black Hole connector documentation indicating a docs-only change
  • Insert a dummy comment in BlackHoleConnector.java to represent a code-only change

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2025
@findepi findepi marked this pull request as draft October 23, 2025 09:19
@github-actions github-actions bot added docs blackhole Blackhole connector labels Oct 23, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds a documentation note and an inline code comment to the BlackHole connector implementation.

File-Level Changes

Change Details Files
Clarify documentation intent
  • Inserted a note indicating the change is docs-only after the overview.
docs/src/main/sphinx/connector/blackhole.md
Annotate code change in connector class
  • Added an inline comment marking a code change in the BlackHoleConnector class.
plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleConnector.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@findepi findepi changed the base branch from master to findepi/docs-checks October 23, 2025 10:11
@findepi
Copy link
Member Author

findepi commented Oct 23, 2025

currently based on #27070

@findepi findepi force-pushed the findepi/docs-checks branch from 4a631d0 to b992071 Compare October 23, 2025 12:16
@findepi findepi force-pushed the findepi/test-docs-and-code-change-on-ci-205e18 branch from ad14014 to c50f4a8 Compare October 23, 2025 13:14
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector lakehouse labels Oct 23, 2025
@findepi findepi force-pushed the findepi/test-docs-and-code-change-on-ci-205e18 branch from c50f4a8 to d2d9e15 Compare October 23, 2025 13:18
@findepi findepi force-pushed the findepi/docs-checks branch from f53b204 to 223d18b Compare October 23, 2025 13:52
@findepi findepi force-pushed the findepi/docs-checks branch 2 times, most recently from 2edda65 to 9f43511 Compare October 23, 2025 15:15
@findepi findepi force-pushed the findepi/docs-checks branch from 212e26e to a0d9b10 Compare October 24, 2025 07:50
@findepi findepi deleted the branch trinodb:findepi/docs-checks October 24, 2025 11:15
@findepi findepi closed this Oct 24, 2025
@findepi findepi deleted the findepi/test-docs-and-code-change-on-ci-205e18 branch October 24, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blackhole Blackhole connector cla-signed delta-lake Delta Lake connector docs hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver lakehouse

Development

Successfully merging this pull request may close these issues.

1 participant