-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove unused ConnectorSplit.getSplitInfo method #27063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR cleans up the ConnectorSplit SPI interface by removing the deprecated getSplitInfo method and its related annotations and imports. Class diagram for ConnectorSplit after removal of getSplitInfoclassDiagram
class ConnectorSplit {
+List<HostAddress> getAddresses()
+SplitWeight getSplitWeight()
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention this change in a release note because it's a change in SPI. A build will fail if third party developers were implementing this method in their connector split class. |
97fb5ea to
371087f
Compare
Description
Additional context and related issues
Release notes
() This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Summary by Sourcery
Remove the deprecated getSplitInfo method and related unused imports from ConnectorSplit interface
Enhancements:
Chores: