Skip to content

Conversation

@chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Oct 23, 2025

Description

Additional context and related issues

Release notes

() This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## SPI
* Remove the deprecated `ConnectorSplit.getSplitInfo` method. ({issue}`27063`)

Summary by Sourcery

Remove the deprecated getSplitInfo method and related unused imports from ConnectorSplit interface

Enhancements:

  • Remove deprecated getSplitInfo method from ConnectorSplit interface

Chores:

  • Remove unused imports of JsonIgnore and Map in ConnectorSplit

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR cleans up the ConnectorSplit SPI interface by removing the deprecated getSplitInfo method and its related annotations and imports.

Class diagram for ConnectorSplit after removal of getSplitInfo

classDiagram
class ConnectorSplit {
  +List<HostAddress> getAddresses()
  +SplitWeight getSplitWeight()
}
Loading

File-Level Changes

Change Details Files
Remove deprecated getSplitInfo method
  • Deleted getSplitInfo default method, its Javadoc, and unsupported operation stub
  • Removed @deprecated(forRemoval = true) annotation
  • Removed @JsonIgnore annotation
  • Removed unused Map import
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorSplit.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ebyhr
Copy link
Member

ebyhr commented Oct 23, 2025

(x) This is not user-visible or is docs only, and no release notes are required.

I think we should mention this change in a release note because it's a change in SPI. A build will fail if third party developers were implementing this method in their connector split class.

@ebyhr ebyhr force-pushed the rm-unused-consplit branch from 97fb5ea to 371087f Compare October 23, 2025 07:19
@ebyhr ebyhr changed the title Remove unused method getSplitInfo Remove unused ConnectorSplit.getSplitInfo method Oct 23, 2025
@ebyhr ebyhr merged commit 5086d8b into trinodb:master Oct 23, 2025
99 checks passed
@github-actions github-actions bot added this to the 478 milestone Oct 23, 2025
@chenjian2664 chenjian2664 deleted the rm-unused-consplit branch October 23, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants