Fix transactional table alter to include thrift catalog name

[anusudarsan]

The HMS image we use by default in the tests is not reproducing the issue, so tested manually with enforcing chosenAlterTransactionalTableAlternative to 1, to trigger the alternate call. This was an alternate call we missed in the original implementation.

Description

Additional context and related issues

Release notes

## Hive
* Fix potential failure when updating or deleting Hive transactional tables and the
  `hive.metastore.thrift.catalog-name` property was configured. ({issue}`27032`)

Summary by Sourcery

Bug Fixes:

• Include the catalog name when calling alterTableWithEnvironmentContext in the alternate alterTransactionalTable path.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes an oversight in the alternate branch of the transactional table alteration logic by ensuring the Thrift client call includes the catalog name when invoking alterTableWithEnvironmentContext.

Sequence diagram for updated transactional table alter call with catalog name

sequenceDiagram
participant "ThriftHiveMetastoreClient"
participant "ThriftMetastoreClient (client)"
"ThriftHiveMetastoreClient"->>"ThriftMetastoreClient (client)": alterTableWithEnvironmentContext(prependCatalogToDbName(catalogName, dbName), tableName, table, environmentContext)

Loading

Class diagram for updated ThriftHiveMetastoreClient.alterTransactionalTable method

classDiagram
class ThriftHiveMetastoreClient {
  +alterTransactionalTable(table, transactionId, writeId)
}
class ThriftMetastoreClient {
  +alterTableWithEnvironmentContext(dbName, tableName, table, environmentContext)
}
ThriftHiveMetastoreClient --> ThriftMetastoreClient : uses
ThriftHiveMetastoreClient ..> prependCatalogToDbName : calls

Loading

File-Level Changes

Change	Details	Files
Include catalog name in alternate transactional table alter call	Replace table.getDbName() with prependCatalogToDbName(catalogName, table.getDbName()) in the fallback alterTableWithEnvironmentContext invocation	plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}