Fix DROP CATALOG spurious failure if cleanupQuery implemented #27025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
findepi
force-pushed
the
findepi/fix-drop-catalog-spurious-failure-if-cleanupquery-implemented-b7775a
branch
2 times, most recently
from
fe5e681 to
39cffa6
Compare
- consistent field name (plural `sessionProperties`) - make field order more consistent
kokosing
reviewed
Oct 21, 2025
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
Before the change, DROP CATALOG could fail if the metadata of the catalog being dropped implements `cleanupQuery` and the `cleanupQuery` checks catalog session properties. This was because inspecting session properties requires catalog to exist and that could have been pruned away. This fixes coordinator catalog pruning to retain catalogs used in active transactions.
findepi
force-pushed
the
findepi/fix-drop-catalog-spurious-failure-if-cleanupquery-implemented-b7775a
branch
from
39cffa6 to
3d9a0ab
Compare
homar
reviewed
Oct 21, 2025
homar
approved these changes
Oct 21, 2025
kokosing
approved these changes
Oct 21, 2025
findepi
deleted the
findepi/fix-drop-catalog-spurious-failure-if-cleanupquery-implemented-b7775a
branch
Member
|
I'm late to review but thank you for finding and fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, DROP CATALOG could fail if the metadata of the
catalog being dropped implements
cleanupQueryand thecleanupQuerychecks catalog session properties. This was because inspecting session
properties requires catalog to exist and that could have been pruned
away. This fixes coordinator catalog pruning to retain catalogs used in
active transactions.
Release notes