Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 20, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

CI:

  • Add cleanup-node: 'true' to the cache restore step in ci.yml

@cla-bot cla-bot bot added the cla-signed label Oct 20, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the GitHub Actions CI configuration to enable cleaning of the test node prior to the Maven install step, ensuring JDBC compatibility tests run in a fresh environment.

File-Level Changes

Change Details Files
Enable CI node cleanup in cache restore step
  • Add ‘cleanup-node: true’ alongside cache restore in the workflow
  • Ensure the node is cleaned before running Maven Install
.github/workflows/ci.yml

Possibly linked issues

  • #Flaky ci / test-jdbc-compatibility job: PR adds cleanup-node: 'true' to resolve resource management issues in the flaky ci / test-jdbc-compatibility job.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Update the PR description to explain why the cleanup-node flag is needed and link relevant documentation.
  • Use a YAML boolean (cleanup-node: true) instead of a string for consistency and readability.
  • Remove or fill out the unused placeholder sections in the PR template to keep the description focused on the actual change.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Update the PR description to explain why the cleanup-node flag is needed and link relevant documentation.
- Use a YAML boolean (cleanup-node: true) instead of a string for consistency and readability.
- Remove or fill out the unused placeholder sections in the PR template to keep the description focused on the actual change.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wendigo wendigo requested a review from Copilot October 20, 2025 13:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a cleanup configuration to the cache restore step in the GitHub Actions CI workflow to improve JDBC compatibility tests.

  • Adds cleanup-node: 'true' parameter to the cache restore step in the CI workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wendigo wendigo requested review from Copilot, ebyhr and losipiuk October 20, 2025 13:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wendigo wendigo merged commit 84d1a9a into master Oct 21, 2025
104 of 106 checks passed
@wendigo wendigo deleted the serafin/cleanup-node-jdbc branch October 21, 2025 08:14
@github-actions github-actions bot added this to the 478 milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants