-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Disable CGroups for Elastic/OpenSearch docker #27019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduces environment variables to disable CGroups support in Docker-based tests for both Elasticsearch and OpenSearch plugins by passing appropriate JVM options. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d565e62 to
fae8259
Compare
fae8259 to
ebcff2f
Compare
|
How did we got master failing? |
| container.withNetwork(network); | ||
| container.withNetworkAliases("elasticsearch-server"); | ||
| container.withStartupTimeout(Duration.ofMinutes(5)); | ||
| container.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport"); // Disable CGroups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all other are defaults that won't be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Disable CGroups
ok, but why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github has changed something on the hosted runners that broke elasticsearch and opensearch. I have no idea what the change is, but it seems that the cgroup memory subsystem is not exposed correctly to the running container
| { | ||
| container = new OpenSearchContainer<>(image); | ||
| container.withNetwork(network); | ||
| container.withEnv("OPENSEARCH_JAVA_OPTS", "-XX:-UseContainerSupport"); // Disable CGroups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need set others like in ES?
|
Github fixed itself 😥 |
one could think it's actually a good thing |
|
@findepi yes but I couldn't find a place to get any information about this change |
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Summary by Sourcery
Disable container-level resource detection for Elasticsearch and OpenSearch Docker test containers by adding the respective Java option to disable UseContainerSupport.
Enhancements: