Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 20, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Disable container-level resource detection for Elasticsearch and OpenSearch Docker test containers by adding the respective Java option to disable UseContainerSupport.

Enhancements:

  • Disable CGroups support in Elasticsearch test container by setting ES_JAVA_OPTS to -XX:-UseContainerSupport
  • Disable CGroups support in OpenSearch test container by setting OPENSEARCH_JAVA_OPTS to -XX:-UseContainerSupport

@cla-bot cla-bot bot added the cla-signed label Oct 20, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces environment variables to disable CGroups support in Docker-based tests for both Elasticsearch and OpenSearch plugins by passing appropriate JVM options.

File-Level Changes

Change Details Files
Disable CGroups support for Elasticsearch test container
  • Add ES_JAVA_OPTS environment variable with '-XX:-UseContainerSupport'
  • Document reasoning via inline comment
plugin/trino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchServer.java
Disable CGroups support for OpenSearch test container
  • Add OPENSEARCH_JAVA_OPTS environment variable with '-XX:-UseContainerSupport'
  • Ensure inline comment aligns with Elasticsearch change
plugin/trino-opensearch/src/test/java/io/trino/plugin/opensearch/OpenSearchServer.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added elasticsearch Elasticsearch connector opensearch OpenSearch connector labels Oct 20, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wendigo wendigo force-pushed the serafin/es-os-cgroups branch 6 times, most recently from d565e62 to fae8259 Compare October 20, 2025 15:29
@wendigo wendigo force-pushed the serafin/es-os-cgroups branch from fae8259 to ebcff2f Compare October 20, 2025 15:40
@wendigo
Copy link
Contributor Author

wendigo commented Oct 20, 2025

@findepi @ebyhr this should fix master failing. Let me know if this needs more elaborate documentation

@findepi
Copy link
Member

findepi commented Oct 20, 2025

How did we got master failing?

container.withNetwork(network);
container.withNetworkAliases("elasticsearch-server");
container.withStartupTimeout(Duration.ofMinutes(5));
container.withEnv("ES_JAVA_OPTS", "-Xmx256m -Xms256m -Dlog4j2.disableJmx=true -Dlog4j2.disable.jmx=true -XX:-UseContainerSupport"); // Disable CGroups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all other are defaults that won't be set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Disable CGroups

ok, but why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github has changed something on the hosted runners that broke elasticsearch and opensearch. I have no idea what the change is, but it seems that the cgroup memory subsystem is not exposed correctly to the running container

{
container = new OpenSearchContainer<>(image);
container.withNetwork(network);
container.withEnv("OPENSEARCH_JAVA_OPTS", "-XX:-UseContainerSupport"); // Disable CGroups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need set others like in ES?

@wendigo
Copy link
Contributor Author

wendigo commented Oct 21, 2025

Github fixed itself 😥

@wendigo wendigo closed this Oct 21, 2025
@findepi
Copy link
Member

findepi commented Oct 21, 2025

Github fixed itself 😥

one could think it's actually a good thing

@findepi findepi deleted the serafin/es-os-cgroups branch October 21, 2025 21:08
@wendigo
Copy link
Contributor Author

wendigo commented Oct 21, 2025

@findepi yes but I couldn't find a place to get any information about this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed elasticsearch Elasticsearch connector opensearch OpenSearch connector

Development

Successfully merging this pull request may close these issues.

3 participants