Don't reuse a table name in testCreateTableWithLongColumnName

[ebyhr]

Description

This should fix flakiness in Cassandra connector.

https://github.com/trinodb/trino/actions/runs/18550092870/job/52875890713

Error:    TestCassandraConnectorTest>BaseConnectorTest.testCreateTableWithLongColumnName:3884 
Expecting value to be false but was true

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Summary by Sourcery

Tests:

• Generate separate random table names for valid and invalid column length tests to avoid table name reuse

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

testCreateTableWithLongColumnName now uses distinct randomized table names for valid and invalid column length checks, preventing reuse-induced flakiness.

Class diagram for updated testCreateTableWithLongColumnName method

classDiagram
    class BaseConnectorTest {
        -tableNameWithValidColumnLength : String
        -tableNameWithInvalidColumnLength : String
        -validColumnName : String
        -invalidColumnName : String
        +testCreateTableWithLongColumnName()
        +assertUpdate(query: String)
        +columnExists(tableName: String, columnName: String) : boolean
        +getQueryRunner() : QueryRunner
        +verifyColumnNameLengthFailurePermissible(exception)
        +maxColumnNameLength() : Optional<Integer>
    }
    class QueryRunner {
        +tableExists(session, tableName: String) : boolean
    }
    BaseConnectorTest --> QueryRunner

Loading

File-Level Changes

Change	Details	Files
Separate table names for valid and invalid column length tests	Renamed initial tableName variable to tableNameWithValidColumnLength Introduced tableNameWithInvalidColumnLength for the invalid column test Updated CREATE, EXISTS, DROP, and exception assertions to reference the correct tableName variables	testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Wrap the valid table creation and drop in a try/finally block to ensure cleanup even if an assertion fails.
• Use distinct table name prefixes like 'test_long_column_valid' and 'test_long_column_invalid' for clearer debugging when tests flop.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Wrap the valid table creation and drop in a try/finally block to ensure cleanup even if an assertion fails.
- Use distinct table name prefixes like 'test_long_column_valid' and 'test_long_column_invalid' for clearer debugging when tests flop.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}