Skip to content

Conversation

@pettyjamesm
Copy link
Member

@pettyjamesm pettyjamesm commented Oct 16, 2025

Description

The implementation was introduced to support RecordingHiveMetastore which has long since been removed. No apparent other usages of these classes exist.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Summary by Sourcery

Chores:

  • Delete BlockJsonSerde, HiveBlockEncodingSerde, and TestHiveBlockEncodingSerde classes and files

The implementation was introduced to support RecordingHiveMetastore
which has long since been removed. No apparent other usages of these
classes exist.
@cla-bot cla-bot bot added the cla-signed label Oct 16, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes obsolete Hive block encoding serde classes (BlockJsonSerde, HiveBlockEncodingSerde) and their test, which became dead code after dropping RecordingHiveMetastore, streamlining the plugin by deleting unused artifacts.

File-Level Changes

Change Details Files
Remove obsolete Hive SerDe classes and tests
  • Deleted BlockJsonSerde implementation
  • Removed HiveBlockEncodingSerde class
  • Deleted TestHiveBlockEncodingSerde
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/BlockJsonSerde.java
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveBlockEncodingSerde.java
plugin/trino-hive/src/test/java/io/trino/plugin/hive/util/TestHiveBlockEncodingSerde.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the hive Hive connector label Oct 16, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pettyjamesm pettyjamesm merged commit 4e425ed into trinodb:master Oct 16, 2025
62 checks passed
@pettyjamesm pettyjamesm deleted the delete-hive-block-serde branch October 16, 2025 20:54
@github-actions github-actions bot added this to the 478 milestone Oct 16, 2025
@electrum
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed hive Hive connector

Development

Successfully merging this pull request may close these issues.

3 participants