-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Stop running product tests with Databricks 11.3 LTS #26959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The new TestDeltaLakeBasic test for databricks113 is no longer included in any CI suite (suite-delta-lake-databricks113 was removed), so it will never run—please re-enable or reassign it to an active suite.
- After consolidating away the 11.3 version checks, verify that all test group annotations still map to existing suites so no tests are inadvertently skipped.
- Consider removing or documenting the remaining databricks113 test resources if they are no longer needed now that 11.3 support is dropped.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new TestDeltaLakeBasic test for databricks113 is no longer included in any CI suite (suite-delta-lake-databricks113 was removed), so it will never run—please re-enable or reassign it to an active suite.
- After consolidating away the 11.3 version checks, verify that all test group annotations still map to existing suites so no tests are inadvertently skipped.
- Consider removing or documenting the remaining databricks113 test resources if they are no longer needed now that 11.3 support is dropped.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| Data generated using Databricks 11.3: | ||
|
|
||
| ```sql | ||
| CREATE TABLE default.region (regionkey bigint, name string, comment string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still needs those files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes because tables created by Databricks 11.3 should be readable even after the EOL.
Description
Databricks 11.3 LTS is going to reach EOL on Oct 19. https://docs.databricks.com/aws/en/release-notes/runtime/
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
Summary by Sourcery
Remove end-of-life Databricks 11.3 LTS from live product tests and CI, clean up obsolete version checks, and add lightweight plugin unit support for reading Databricks 11.3 data
Enhancements:
CI: