Revert "Disable Snowflake tests"

[wendigo]

This reverts commit d081019.

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Re-enable Snowflake tests by reverting the previous disablement in the CI workflow and test code.

CI:

• Restore trino-snowflake entries in the CI matrix and remove the conditional skip to run Snowflake cloud-tests again
• Add suite-snowflake to the integration test suites

Tests:

• Remove @disabled annotations from TestIcebergSnowflakeCatalogConnectorSmokeTest and TestTrinoSnowflakeCatalog to enable their execution

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Re-enable Snowflake integration tests by restoring the CI workflow to include the trino-snowflake plugin and cloud-tests profile, removing the temporary disable condition, and un-disabling the associated smoke test classes.

Class diagram for re-enabled Snowflake smoke test classes

classDiagram
  class TestIcebergSnowflakeCatalogConnectorSmokeTest {
    +void testSmoke()
    +void testOtherCases()
  }
  class TestTrinoSnowflakeCatalog {
    +void testCatalogConnection()
    +void testCatalogOperations()
  }
  TestIcebergSnowflakeCatalogConnectorSmokeTest <|-- TestTrinoSnowflakeCatalog

Loading

File-Level Changes

Change	Details	Files
Re-enable Snowflake plugin tests in CI workflow	Add plugin/trino-snowflake and cloud-tests profile entries to the CI modules matrix Remove the temporary 'false &&' disable condition for Snowflake cloud-tests Include suite-snowflake in the product test matrix	.github/workflows/ci.yml
Un-disable Snowflake connector smoke tests	Remove @disabled annotation from TestIcebergSnowflakeCatalogConnectorSmokeTest Remove @disabled annotation from TestTrinoSnowflakeCatalog	plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/snowflake/TestIcebergSnowflakeCatalogConnectorSmokeTest.java plugin/trino-iceberg/src/test/java/org/apache/iceberg/snowflake/TestTrinoSnowflakeCatalog.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}