Skip to content

Conversation

chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Oct 14, 2025

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Enhancements:

  • Skip v2 checkpoint processing and sidecar file retrieval when no supported data entry types are present

@cla-bot cla-bot bot added the cla-signed label Oct 14, 2025
Copy link

sourcery-ai bot commented Oct 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Optimizes getV2CheckpointTransactionLogEntries by short-circuiting when there are no ADD/REMOVE entry types, preventing unnecessary sidecar file processing.

Flow diagram for early exit in getV2CheckpointTransactionLogEntries

flowchart TD
    A["getV2CheckpointTransactionLogEntries called"] --> B["Compute intersection of entryTypes and {ADD, REMOVE}"]
    B --> C{Is dataEntryTypes empty?}
    C -- Yes --> D["Return empty Stream"]
    C -- No --> E["Proceed to getV2CheckpointEntries and process sidecar files"]
Loading

File-Level Changes

Change Details Files
Early exit when no relevant entry types
  • Compute intersection of requested entry types with ADD and REMOVE
  • Return an empty stream if the intersection is empty
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java
Simplify sidecar null check in lambda
  • Remove redundant check for empty dataEntryTypes inside the lambda
  • Keep only the sidecar null condition to return single-entry streams
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the delta-lake Delta Lake connector label Oct 14, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ebyhr
Copy link
Member

ebyhr commented Oct 14, 2025

@chenjian2664 Could you fix CI failures?

@chenjian2664 chenjian2664 force-pushed the v2_checkpoint_early_stop branch from 98caac1 to c955581 Compare October 14, 2025 09:46
@chenjian2664
Copy link
Contributor Author

updated

@ebyhr ebyhr merged commit 2f99d64 into trinodb:master Oct 14, 2025
23 of 24 checks passed
@github-actions github-actions bot added this to the 478 milestone Oct 14, 2025
@chenjian2664 chenjian2664 deleted the v2_checkpoint_early_stop branch October 14, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed delta-lake Delta Lake connector

Development

Successfully merging this pull request may close these issues.

3 participants