-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove Vertica connector #26904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove Vertica connector #26904
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR excises the unmaintained Vertica connector by stripping its module and dependency entries, purging related provisioning, documentation, CI/test configurations, and removing the plugin implementation and tests. Class diagram for removed Vertica connector classesclassDiagram
class VerticaPlugin {
+getConnectorFactories()
}
class VerticaClient {
+VerticaClient()
+getConnection()
+executeQuery()
}
class VerticaClientModule {
+configure()
}
class VerticaDriver {
+connect()
+disconnect()
}
class VerticaTableStatisticsReader {
+readStatistics()
}
%% Test classes
class BaseVerticaConnectorSmokeTest {
+testBasicQueries()
}
class TestVerticaConnectorSmokeTest {
+testSmoke()
}
class TestVerticaConnectorTest {
+testConnector()
}
class TestVerticaLatestConnectorSmokeTest {
+testLatestSmoke()
}
class TestVerticaPlugin {
+testPluginLoad()
}
class TestVerticaTableStatistics {
+testStatistics()
}
class TestVerticaTypeMapping {
+testTypeMapping()
}
class TestingVerticaServer {
+start()
+stop()
}
class VerticaQueryRunner {
+runQuery()
}
%% All above classes were removed in this PR
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
FYI, https://trinodb.slack.com/archives/C07ABNN828M/p1755729147128999 is the relevant Slack thread. I'm waiting for a reply from OpenText. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we were to add this connector today, lack of testability options would be a blocker
for that reason, I consider this a rational move.
keeping it inline, but without ability to run tests, will make developing new features and new connector changes harder.
The connector may find new home outside of core trino repo, but still within trinodb org. It should be removed from here first, to define clear cut off version. Additionally, such a move should not be done, if there are no enough volunteers wishing to maintain the connector.
Description
I propose removing the Vertica connector since OpenText has removed all Docker images from Docker Hub.
We shouldn't release an untested connector.
vertica/vertica-containers#64 (comment) is a comment from OpenText:
Release notes
Summary by Sourcery
Remove the unsupported Vertica connector and all related build modules, code, tests, CI configuration, and documentation.
Build:
CI:
Documentation:
Tests: