Skip to content

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 9, 2025

Description

I propose removing the Vertica connector since OpenText has removed all Docker images from Docker Hub.
We shouldn't release an untested connector.

vertica/vertica-containers#64 (comment) is a comment from OpenText:

Hello All, Vertica Community Edition is being replaced with a Timed Trial that will require registration.

For Open-Source development, please utilize one of the following options moving forward to support your dev/test initiatives:

  1. Timed Trial (coming soon)
  2. One of our Vertica by the Hour options
    AWS Marketplace: Vertica by the Hour
    Google Marketplace: Vertica Data Warehouse, Eon by the Hour
  3. Contact OT-Vertica Sales for a Development License by accessing this webpage and choosing the "Contact Us" option. Please complete the online form and submit. You request will be routed to the appropriate team.

Thanks very much, OT-Vertica Product Management

Release notes

## General
* Remove the Vertica connector. ({issue}`issuenumber`)

Summary by Sourcery

Remove the unsupported Vertica connector and all related build modules, code, tests, CI configuration, and documentation.

Build:

  • Remove trino-vertica build module and dependency entries

CI:

  • Remove CI workflow steps and GitHub labeler config for the Vertica connector

Documentation:

  • Remove all documentation references, download links, and redirect entries for the Vertica connector

Tests:

  • Delete Vertica connector tests and remove Vertica from product test environments

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2025
Copy link

sourcery-ai bot commented Oct 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR excises the unmaintained Vertica connector by stripping its module and dependency entries, purging related provisioning, documentation, CI/test configurations, and removing the plugin implementation and tests.

Class diagram for removed Vertica connector classes

classDiagram
  class VerticaPlugin {
    +getConnectorFactories()
  }
  class VerticaClient {
    +VerticaClient()
    +getConnection()
    +executeQuery()
  }
  class VerticaClientModule {
    +configure()
  }
  class VerticaDriver {
    +connect()
    +disconnect()
  }
  class VerticaTableStatisticsReader {
    +readStatistics()
  }
  %% Test classes
  class BaseVerticaConnectorSmokeTest {
    +testBasicQueries()
  }
  class TestVerticaConnectorSmokeTest {
    +testSmoke()
  }
  class TestVerticaConnectorTest {
    +testConnector()
  }
  class TestVerticaLatestConnectorSmokeTest {
    +testLatestSmoke()
  }
  class TestVerticaPlugin {
    +testPluginLoad()
  }
  class TestVerticaTableStatistics {
    +testStatistics()
  }
  class TestVerticaTypeMapping {
    +testTypeMapping()
  }
  class TestingVerticaServer {
    +start()
    +stop()
  }
  class VerticaQueryRunner {
    +runQuery()
  }
  %% All above classes were removed in this PR
Loading

File-Level Changes

Change Details Files
Remove Vertica connector module references and dependencies
  • Deleted trino-vertica from the top-level pom
  • Removed trino-vertica dependency declaration
pom.xml
Remove Vertica provisioning configuration
  • Deleted the Vertica artifactSet block in Trino provisioning
core/trino-server/src/main/provisio/trino.xml
Clean up documentation for Vertica connector
  • Removed Vertica entries from installation guide, connector listing, and release notes
  • Deleted download extension mapping and redirects for Vertica
docs/src/main/sphinx/installation/plugins.md
docs/src/main/sphinx/release/release-464.md
docs/release-template.md
docs/src/main/sphinx/connector.md
docs/src/main/sphinx/ext/download.py
docs/src/main/sphinx/redirects.txt
docs/src/main/sphinx/connector/vertica.md
Update CI and labeling configuration to drop Vertica references
  • Removed Vertica from CI job definitions and module lists
  • Deleted Vertica labeler config section
.github/config/labeler-config.yml
.github/workflows/ci.yml
Remove Vertica from product test environments
  • Excluded Vertica connector in EnvMultinodeAllConnectors
  • Deleted Vertica environment properties file
testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeAllConnectors.java
testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-all/vertica.properties
Delete Vertica connector implementation and tests
  • Removed entire plugin/trino-vertica directory including source code and tests
plugin/trino-vertica/**

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@wendigo
Copy link
Contributor

wendigo commented Oct 10, 2025

I'm fine with a drop but let's hear @martint @mosabua thoughts on this one

@ebyhr
Copy link
Member Author

ebyhr commented Oct 10, 2025

FYI, https://trinodb.slack.com/archives/C07ABNN828M/p1755729147128999 is the relevant Slack thread. I'm waiting for a reply from OpenText.

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we were to add this connector today, lack of testability options would be a blocker
for that reason, I consider this a rational move.
keeping it inline, but without ability to run tests, will make developing new features and new connector changes harder.

The connector may find new home outside of core trino repo, but still within trinodb org. It should be removed from here first, to define clear cut off version. Additionally, such a move should not be done, if there are no enough volunteers wishing to maintain the connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants