Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 9, 2025

Closes #26860

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Documentation:

  • Add entry for disallowLocalRedirect to describe rejecting redirects to localhost and site-local IPs

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 9, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@wendigo wendigo requested a review from ebyhr October 9, 2025 09:26
@github-actions github-actions bot added the docs label Oct 9, 2025
@wendigo wendigo force-pushed the serafin/document-disallowLocalRedirect branch from 08cb9c5 to 10a20b4 Compare October 9, 2025 09:26
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wendigo wendigo force-pushed the serafin/document-disallowLocalRedirect branch from 10a20b4 to 9850250 Compare October 9, 2025 09:31
@wendigo wendigo force-pushed the serafin/document-disallowLocalRedirect branch from 9850250 to b3a3d2b Compare October 9, 2025 09:35
@wendigo wendigo requested a review from ebyhr October 9, 2025 09:58
@wendigo
Copy link
Contributor Author

wendigo commented Oct 9, 2025

@ebyhr I've added one more doc change. PTAL

@wendigo wendigo merged commit b281ece into trinodb:master Oct 9, 2025
9 checks passed
@github-actions github-actions bot added this to the 478 milestone Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Document disallowLocalRedirect option in Trino clients

2 participants