Skip to content

Revert SPI change #26843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

Revert SPI change #26843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions core/trino-spi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,15 +230,6 @@
<new>method void io.trino.spi.connector.Connector::shutdown()</new>
<justification>Require connector to implement shutdown to prevent leaks</justification>
</item>
<item>
<ignore>true</ignore>
<code>java.method.visibilityReduced</code>
<old>method java.lang.String io.trino.spi.QueryId::validateId(java.lang.String)</old>
<new>method java.lang.String io.trino.spi.QueryId::validateId(java.lang.String, java.lang.String)</new>
<oldVisibility>public</oldVisibility>
<newVisibility>package</newVisibility>
<justification>Hidden method that is not used outside of QueryId</justification>
</item>
<item>
<code>java.annotation.removed</code>
<old>method java.lang.String io.trino.spi.QueryId::toString()</old>
Expand Down
6 changes: 3 additions & 3 deletions core/trino-spi/src/main/java/io/trino/spi/QueryId.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static QueryId valueOf(String queryId)
{
requireNonNull(id, "id is null");
checkArgument(!id.isEmpty(), "id is empty");
validateId("queryId", id);
validateId(id);
}

// For backward compatibility
Expand Down Expand Up @@ -79,10 +79,10 @@ private static boolean isValidDottedId(char[] chars)
return true;
}

static String validateId(String name, String id)
public static String validateId(String id)
{
if (!isValidId(id)) {
throw new IllegalArgumentException("Invalid " + name + " " + id);
throw new IllegalArgumentException("Invalid queryId " + id);
}
return id;
}
Expand Down