Skip to content

Remove deprecated EncoderUtil.encodeNullsAsBits #26781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

Remove deprecated EncoderUtil.encodeNullsAsBits #26781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions core/trino-spi/src/main/java/io/trino/spi/block/EncoderUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,52 +68,6 @@ public static void encodeNullsAsBits(SliceOutput sliceOutput, @Nullable boolean[
sliceOutput.writeBytes(packedIsNull, 0, currentByte);
}

/**
* Append null values for the block as a stream of bits.
*
* @deprecated Use {@link EncoderUtil#encodeNullsAsBits(SliceOutput, boolean[], int, int)} instead
*/
@Deprecated(forRemoval = true)
@SuppressWarnings({"NarrowingCompoundAssignment", "ImplicitNumericConversion"})
public static void encodeNullsAsBits(SliceOutput sliceOutput, Block block)
{
boolean mayHaveNull = block.mayHaveNull();
sliceOutput.writeBoolean(mayHaveNull);
if (!mayHaveNull) {
return;
}

int positionCount = block.getPositionCount();
byte[] packedIsNull = new byte[((positionCount & ~0b111) + 1) / 8];
int currentByte = 0;

for (int position = 0; position < (positionCount & ~0b111); position += 8, currentByte++) {
byte value = 0;
value |= block.isNull(position) ? 0b1000_0000 : 0;
value |= block.isNull(position + 1) ? 0b0100_0000 : 0;
value |= block.isNull(position + 2) ? 0b0010_0000 : 0;
value |= block.isNull(position + 3) ? 0b0001_0000 : 0;
value |= block.isNull(position + 4) ? 0b0000_1000 : 0;
value |= block.isNull(position + 5) ? 0b0000_0100 : 0;
value |= block.isNull(position + 6) ? 0b0000_0010 : 0;
value |= block.isNull(position + 7) ? 0b0000_0001 : 0;
packedIsNull[currentByte] = value;
}

sliceOutput.writeBytes(packedIsNull);

// write last null bits
if ((positionCount & 0b111) > 0) {
byte value = 0;
int mask = 0b1000_0000;
for (int position = positionCount & ~0b111; position < positionCount; position++) {
value |= block.isNull(position) ? mask : 0;
mask >>>= 1;
}
sliceOutput.appendByte(value);
}
}

/**
* Decode the bit stream created by encodeNullsAsBits.
*/
Expand Down